Require full expression parse match #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hussein-awala
approved these changes
Oct 21, 2023
Member
hussein-awala
left a comment
hussein-awala
left a comment
There was a problem hiding this comment.
Nice catch! I just tested it, and all the filters seem to be considered now.
Fokko
reviewed
Oct 21, 2023
Fokko
approved these changes
Oct 21, 2023
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
Small suggestion on the test, apart from that it looks like a good change to me
Co-authored-by: Fokko Driesprong <fokko@apache.org>
Fokko
added a commit
that referenced
this pull request
Oct 24, 2023
* Require full expression parse match * Codestyle * Update tests/expressions/test_parser.py Co-authored-by: Fokko Driesprong <fokko@apache.org> --------- Co-authored-by: Fokko Driesprong <fokko@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.