Skip to content

Require full expression parse match #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielcweeks merged 3 commits into from
Oct 21, 2023
Merged

Require full expression parse match #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b368a86
Require full expression parse match
danielcweeks Oct 21, 2023
4a0c32e
Codestyle
danielcweeks Oct 21, 2023
748ce38
Update tests/expressions/test_parser.py
danielcweeks Oct 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyiceberg/expressions/parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,4 +252,4 @@ def handle_or(result: ParseResults) -> Or:

def parse(expr: str) -> BooleanExpression:
"""Parse a boolean expression."""
return boolean_expression.parse_string(expr)[0]
return boolean_expression.parse_string(expr, parse_all=True)[0]
7 changes: 7 additions & 0 deletions tests/expressions/test_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,3 +166,10 @@ def test_starts_with() -> None:

def test_not_starts_with() -> None:
assert NotStartsWith("foo", "data") == parser.parse("foo NOT LIKE 'data'")


def test_with_function() -> None:
with pytest.raises(ParseException) as exc_info:
parser.parse("foo = 1 and lower(bar) = '2'")

assert "Expected end of text, found 'and'" in str(exc_info)