infra: dynamically set msrv in github workflows #2040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
liurenjie1024
approved these changes
Jan 19, 2026
Contributor
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @kevinjqliu for this fix!
liurenjie1024
pushed a commit
that referenced
this pull request
Jan 20, 2026
## Which issue does this PR close? - Closes #2038 ## What changes are included in this PR? Get MSRV by parsing `rust-version` from `Cargo.toml`. This is to avoid forgetting to update MSRV version in the github workflow. ## Are these changes tested?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Get MSRV by parsing
rust-versionfromCargo.toml. This is to avoid forgetting to update MSRV version in the github workflow.Are these changes tested?