infra: use spark base image for docker #2043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinjqliu
commented
Jan 18, 2026
Comment on lines
-21
to
-24
| # The configuration is important, otherwise we get many small | ||
| # parquet files with a single row. When a positional delete | ||
| # hits the Parquet file with one row, the parquet file gets | ||
| # dropped instead of having a merge-on-read delete file. |
Contributor
Author
There was a problem hiding this comment.
.coalesce(1) below has the same effect
Contributor
Author
There was a problem hiding this comment.
This was referenced Jan 18, 2026
liurenjie1024
approved these changes
Jan 19, 2026
Contributor
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @kevinjqliu for this fix!
Contributor
|
We need to resolve conflicts first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
We made some upgrades to the Spark Dockerfile in pyiceberg (apache/iceberg-python#2540) (which i think rust's Dockerfile copied over previously). Porting those changes over:
apache/sparkas base image (should be faster than downloading spark from apache cdn)Are these changes tested?
Yes