Skip to content

Conversation

@findepi
Copy link
Member

@findepi findepi commented Jun 10, 2024

This guarantees the build will succeed locally.

@github-actions github-actions bot added the INFRA label Jun 10, 2024
@findepi findepi requested a review from Fokko June 10, 2024 08:52
This was referenced Jun 10, 2024
@findepi findepi requested a review from szehon-ho June 11, 2024 07:53
@findepi findepi force-pushed the findepi/run-ci-checks-on-all-supported-jdks-6ce562 branch from c855e64 to 650d66e Compare June 17, 2024 16:02
@findepi
Copy link
Member Author

findepi commented Jun 17, 2024

rebased to resolve conflicts

@findepi findepi requested review from ajantha-bhat and nastra June 17, 2024 16:02
@findepi
Copy link
Member Author

findepi commented Jun 20, 2024

thanks for review and approval @nastra . Do you also want to merge this?

@nastra
Copy link
Contributor

nastra commented Jun 20, 2024

I'll leave it open for a bit to give others a chance to review

This guarantees the build will succeed locally.
@findepi findepi force-pushed the findepi/run-ci-checks-on-all-supported-jdks-6ce562 branch from 650d66e to 0b2fa7d Compare June 27, 2024 19:50
@findepi
Copy link
Member Author

findepi commented Jun 27, 2024

Rebased after #8486 was merged, to make sure there is no logical merge conflict.
It hopefully might be ready to go.

@nastra nastra merged commit 91fbcaa into apache:main Jun 28, 2024
@findepi findepi deleted the findepi/run-ci-checks-on-all-supported-jdks-6ce562 branch June 28, 2024 07:07
@findepi
Copy link
Member Author

findepi commented Jun 28, 2024

thanks @nastra !

jasonf20 pushed a commit to jasonf20/iceberg that referenced this pull request Aug 4, 2024
This guarantees the build will succeed locally.
zachdisc pushed a commit to zachdisc/iceberg that referenced this pull request Dec 23, 2024
This guarantees the build will succeed locally.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants