Skip to content

Conversation

@findepi
Copy link
Member

@findepi findepi commented Jun 10, 2024

This is in preparation for supporting builds on JDK 21. Gradle 8.1.1
does not support running on JDK 21. At least 8.5 is needed.

findepi added 2 commits June 10, 2024 16:21
This guarantees the build will succeed locally.
This is in preparation for supporting builds on JDK 21.  Gradle 8.1.1
does not support running on JDK 21. At least 8.5 is needed.
runs-on: ubuntu-22.04
strategy:
matrix:
jvm: [8, 11, 17]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first commit comes from #10473

@Fokko
Copy link
Contributor

Fokko commented Jun 11, 2024

Semi duplicate of #8486

@findepi Thanks for raising this, and we're working on getting the Gradle version bumped to a later one. @jbonofre is doing some great work in #10386 because the rev-api doesn't work with a later version than the one that we're using now.

Some context: This is part of Iceberg 1.6.0, see devlist. Upgrading Gradle is also required to bump Parquet because that uses a later version of Jackson, which carries some JDK 17+ specific files, and the current shadow plugin is unable to work with that. See #10209 for more context.

Once #10386 goes in, we can bump Gradle 🎉

@findepi
Copy link
Member Author

findepi commented Jun 11, 2024

thanks @Fokko
closing in favor of #8486

@findepi findepi closed this Jun 11, 2024
@findepi findepi deleted the findepi/main/update-gradle-to-8-8-dce8ee branch June 11, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants