Skip to content

Arrow: Remove dead code #11276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nastra merged 1 commit into from
Oct 8, 2024
Merged

Arrow: Remove dead code #11276

nastra merged 1 commit into from
Oct 8, 2024

Conversation

@wypoon
Copy link
Contributor

@wypoon wypoon commented Oct 8, 2024 •
edited
Loading

Remove unused vectorized Parquet readers.

@github-actions github-actions bot added the arrow label Oct 8, 2024
@wypoon wypoon changed the title Arrow: Remove dead code. Arrow: Remove dead code Oct 8, 2024
@wypoon wypoon mentioned this pull request Oct 8, 2024
Merged
nastra
nastra approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@nastra nastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for cleaning that up

@nastra nastra merged commit 208ab20 into apache:main Oct 8, 2024
@wypoon
Copy link
Contributor Author

wypoon commented Oct 8, 2024

Thanks @nastra.
FYI, with this change, DecimalVectorUtil is no longer used (except in tests for it). It is a public class with a public method.

@wypoon wypoon mentioned this pull request Oct 9, 2024
Merged
@dramaticlly dramaticlly mentioned this pull request Oct 21, 2024
Closed
3 tasks
zachdisc pushed a commit to zachdisc/iceberg that referenced this pull request Dec 23, 2024
@wypoon @zachdisc
Arrow: Remove unused readers (apache#11276)
433ba39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nastra nastra nastra approved these changes

Assignees

No one assigned

Labels

arrow

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wypoon @nastra