-
Notifications
You must be signed in to change notification settings - Fork 3k
Arrow: Deprecate unused fixed width binary reader classes #11292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| public FixedWidthTypeBinaryBatchReader fixedWidthTypeBinaryBatchReader() { | ||
| return new FixedWidthTypeBinaryBatchReader(); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw in my IDE that this method is never called, which means that the chain of fixed width binary reader classes are never used.
|
@nastra I missed noticing earlier that the fixed width binary reader classes are no longer used. |
| } | ||
| } | ||
|
|
||
| public class FixedWidthTypeBinaryBatchReader extends BatchReader { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we can just remove this. We should add a deprecation message (@deprecated since 1.7.0, will be removed in 1.8.0) here and to fixedWidthTypeBinaryBatchReaderas it's possible that consumers of Iceberg could use this. See also #3249 on how we did the deprecation and #7987 later removed this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I will deprecate rather than remove the unused code.
There was no revapi failure, so I thought the removal was ok.
In any case, it's a useful exercise to show that with the code removed, the build and all tests still pass.
... for future removal.
6f7dbd6 to
c2e1ce4
Compare
For fixed width binary, the FixedSizeBinaryXXX readers are actually used.
In
VectorizedArrowReader::read:This is a follow-up to #11276.