Spark 3.5: Fix RewriteDataFiles with partial progress enabled and max-failed-commits larger than total-file-group #12120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Member
Author
|
cc @nastra @aokolnychyi who have previously reviewed #9611 |
nastra
reviewed
Feb 12, 2025
...k/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java
Show resolved
Hide resolved
Member
Author
|
@nastra can you please take another look? |
Member
Author
|
@ajantha-bhat I'd like to have this fix reviewed and included in 1.9.0. |
manuzhang
requested review from
ajantha-bhat
and removed request for
ruotianwang
Member
|
cc: @RussellSpitzer |
...k/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java
Outdated
Show resolved
Hide resolved
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java
Show resolved
Hide resolved
pvary
approved these changes
Mar 28, 2025
…-failed-commits larger than total-file-group
RussellSpitzer
approved these changes
Apr 1, 2025
Member
|
Merged! Thanks @manuzhang for the PR and thanks @pvary and @nastra for reviewing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #12076