Spark 3.4: Fix RewriteDataFiles with partial progress enabled and max-failed-commits larger than total-file-group #12701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-failed-commits larger than total-file-group
singhpk234
approved these changes
Apr 1, 2025
Contributor
singhpk234
left a comment
singhpk234
left a comment
There was a problem hiding this comment.
LGTM, Thanks @manuzhang !
RussellSpitzer
approved these changes
Apr 1, 2025
ebyhr
approved these changes
Apr 1, 2025
nastra
approved these changes
Apr 2, 2025
wypoon
reviewed
May 31, 2025
| } | ||
|
|
||
| @TestTemplate | ||
| public void testParallelPartialProgressWithMaxFailedCommitsLargerThanTotalFileGroup() { |
Contributor
There was a problem hiding this comment.
This test seems to be flaky.
I have encountered it failing in the CI for PRs unrelated to RewriteDataFilesSparkAction. I don't have access to manually retrigger the CI, so I have to use some trivial changes to the PRs to retrigger it and then the test passes.
Nevertheless, this is a problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back-port of #12120