Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the iceberg-mr/iceberg-hive3 tests are beginning to take serious amount of time.
This is partially because every tests are run 24 times (2 Engines X 3 FileFormats X 4 Catalogs). We can separate out some of the tests which does not depend the FileFormat/Catalog and this way we can save time.
Also the Catalog tests are still using inheritance which we can replace with parametrized tests for cleaner code.
The current patch is above #1612 since I do not want to rebase that patch again 😄