Hive: Refactor HiveIcebergStorageHandler tests to use catalogs as parameters #1840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Contributor
Author
|
@marton-bod, @lcspinter: Would you mind reviewing the changes? Thanks, |
marton-bod
reviewed
Dec 1, 2020
mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandler.java
Outdated
Show resolved
Hide resolved
mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandler.java
Outdated
Show resolved
Hide resolved
marton-bod
approved these changes
Dec 2, 2020
Collaborator
marton-bod
left a comment
marton-bod
left a comment
There was a problem hiding this comment.
LGTM now, thanks @pvary!
Contributor
Author
|
@rdblue, @shardulm94: Could you please review? |
shardulm94
approved these changes
Dec 4, 2020
Contributor
shardulm94
left a comment
shardulm94
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks @pvary!
Contributor
Author
|
Thanks @marton-bod for the review and @shardulm94 for the review and the push! |
pvary
pushed a commit
to pvary/iceberg
that referenced
this pull request
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #1757 (Hive test refactor) we first should get rid of the HiveIcebergStorageHandlerCatalog test inheritance, replace it with parametrized tests