Skip to content

Strict projection for dates timestamps#287

Closed
moulimukherjee wants to merge 9 commits intoapache:masterfrom
moulimukherjee:strict-projection-for-dates-timestamps
Closed

Strict projection for dates timestamps#287
moulimukherjee wants to merge 9 commits intoapache:masterfrom
moulimukherjee:strict-projection-for-dates-timestamps

Conversation

@moulimukherjee
Copy link
Copy Markdown
Contributor

Implementing strict projection for Dates and Timestamps #35

Handling only the boundaries instead of #283

@moulimukherjee
Copy link
Copy Markdown
Contributor Author

Expected behaviour: ts > 2019-07-07T23:59:59.9999 can be projected strict using ts_day >= 2019-07-08

But for ts > 2019-07-07T15:46:37.89789, ts_day >= 2019-07-08 will only return a subset of the records (not returning records between 15th hour and last hour of 2019-07-07), so it cannot be a strict projection based on https://github.com/apache/incubator-iceberg/blob/master/api/src/main/java/org/apache/iceberg/expressions/ResidualEvaluator.java#L203

@moulimukherjee moulimukherjee changed the title WIP: Strict projection for dates timestamps Strict projection for dates timestamps Jul 15, 2019
@moulimukherjee
Copy link
Copy Markdown
Contributor Author

@rdblue Does this look sane?

@moulimukherjee
Copy link
Copy Markdown
Contributor Author

After discussing offline, this behaviour is not accurate. Closing.

@moulimukherjee moulimukherjee deleted the strict-projection-for-dates-timestamps branch July 24, 2020 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants