Add projectStrict for Dates and Timestamps#283
Merged
rdblue merged 21 commits intoapache:masterfrom Jul 26, 2019
Merged
Conversation
moulimukherjee
force-pushed
the
implement-strict-projection
branch
from
4d3f6d1 to
c3620e5
Compare
Contributor
Author
|
Expected behaviour: |
moulimukherjee
changed the title
Contributor
Author
|
@rdblue Is it apparent to you what might be the issue here? In |
moulimukherjee
force-pushed
the
implement-strict-projection
branch
from
4da4c29 to
2e6dec8
Compare
moulimukherjee
force-pushed
the
implement-strict-projection
branch
from
2e6dec8 to
f976325
Compare
moulimukherjee
commented
Jul 18, 2019
Contributor
Author
|
@rdblue ptal? |
rdblue
reviewed
Jul 24, 2019
|
|
||
| List<UnboundPredicate<?>> strictProjections = Lists.transform(parts, | ||
| part -> ((Transform<T, ?>) part.transform()).projectStrict(part.name(), pred)); | ||
| for (PartitionField part : parts) { |
Contributor
There was a problem hiding this comment.
I like how you restructured this to simply return alwaysTrue or alwaysFalse if any projection can determine the result. That's a lot simpler than before.
rdblue
reviewed
Jul 24, 2019
rdblue
reviewed
Jul 24, 2019
rdblue
reviewed
Jul 24, 2019
rdblue
reviewed
Jul 24, 2019
Refactored and removed predicateInclusive Updated and added more comments
Simplifying the LT and GT predicates and updating tests to reflect that
Contributor
Author
|
@rdblue ptal again? |
rdblue
reviewed
Jul 26, 2019
rdblue
reviewed
Jul 26, 2019
rdblue
reviewed
Jul 26, 2019
rdblue
reviewed
Jul 26, 2019
rdblue
reviewed
Jul 26, 2019
moulimukherjee
commented
Jul 26, 2019
| result, | ||
| ((Transform<T, ?>) part.transform()).project(part.name(), pred)); | ||
| UnboundPredicate<?> inclusiveProjection = ((Transform<T, ?>) part.transform()).project(part.name(), pred); | ||
| if (inclusiveProjection != null) { |
Contributor
Author
There was a problem hiding this comment.
added null check
Contributor
|
Merged. Thanks for working on this, @moulimukherjee! |
danielcweeks
pushed a commit
that referenced
this pull request
Aug 1, 2019
* Add argument validation to HadoopTables#create (#298) * Install source JAR when running install target (#310) * Add projectStrict for Dates and Timestamps (#283) * Correctly publish artifacts on JitPack (#321) The Gradle install target produces invalid POM files that are missing the dependencyManagement section and versions for some dependencies. Instead, we directly tell JitPack to run the correct Gradle target. * Add build info to README.md (#304) * Convert Iceberg time type to Hive string type (#325) * Add overwrite option to write builders (#318) * Fix out of order Pig partition fields (#326) * Add mapping to Iceberg for external name-based schemas (#338) * Site: Fix broken link to Iceberg API (#333) * Add forTable method for Avro WriteBuilder (#322) * Remove multiple literal strings check rule for scala (#335) * Fix invalid javadoc url in README.md (#336) * Use UnicodeUtil.truncateString for Truncate transform. (#340) This truncates by unicode codepoint instead of Java chars. * Refactor metrics tests for reuse (#331) * Spark: Add support for write-audit-publish workflows (#342) * Avoid write failures if metrics mode is invalid (#301) * Fix truncateStringMax in UnicodeUtil (#334) Fixes #328, fixes #329. Index to codePointAt should be the offset calculated by code points * [Vectorization] Added batch sizing, switched to BufferAllocator, other minor style fixes.
rdblue
pushed a commit
to rdblue/iceberg
that referenced
this pull request
Aug 7, 2019
rdblue
pushed a commit
to rdblue/iceberg
that referenced
this pull request
Aug 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing projectStrict for Dates and Timestamps (#35)
Includes fix of ResidualEvaluator from moulimukherjee#1
Expected behaviour:
ts > 2019-07-07T23:59:59.9999 will be projected strict using ts_day >= 2019-07-08
ts > 2019-07-07T15:52:50.0000 will also be projected strict using ts_day >= 2019-07-08
ts > 2019-07-07T00:00:00:0000 will be projected strict using ts_day >= 2019-07-07