Add some checks for HadoopTables#create#298
Merged
rdblue merged 4 commits intoapache:masterfrom Jul 25, 2019
Merged
Conversation
Collaborator
Author
|
close and reopen to trigger CI. |
rdblue
reviewed
Jul 19, 2019
| * | ||
| * @param schema iceberg schema used to create the table | ||
| * @param spec partition specification | ||
| * @param properties properties of the table to be created |
Contributor
There was a problem hiding this comment.
Can you note that null is accepted?
Also, should we do something similar for spec? If spec is null, we could use PartitionSpec.unpartitioned().
Collaborator
Author
There was a problem hiding this comment.
Sure, please see the latest code change.
Collaborator
Author
|
Recently, some unit tests fail randomly. Close and reopen to trigger CI again. We need to fix that. |
rdblue
reviewed
Jul 24, 2019
| * | ||
| * @param schema iceberg schema used to create the table | ||
| * @param spec partition specification | ||
| * @param spec partition specification. It can be null in case of unpartitioned table |
Contributor
There was a problem hiding this comment.
How about "partitioning spec, if null the table will be unpartitioned"
rdblue
reviewed
Jul 24, 2019
| * @param schema iceberg schema used to create the table | ||
| * @param spec partition specification | ||
| * @param spec partition specification. It can be null in case of unpartitioned table | ||
| * @param properties properties of the table to be created, it can be null |
Contributor
There was a problem hiding this comment.
How about "a string map of table properties, initialized to empty if null"
danielcweeks
pushed a commit
that referenced
this pull request
Jul 26, 2019
* First cut impl of reading Parquet FileIterator into ArrowRecordBatch based reader * made num records per arrow batch configurable * addressed comments * Added docs for public methods and ArrowReader class * Fixed javadoc * WIP first stab at reading into Arrow and returning as InternalRow iterator * Add publish to snapshot repository by replacing version to `1.0-adobe-2.0-SNAPSHOT` (snapshot prefix is required by snapshot repo) * Adding arrow schema conversion utility * adding arrow-vector dep to tests * [WIP] Working vectorization for primitive types. Added test for VectorizedSparkParquetReaders. * [WIP] Added Decimal types to vectorization * [WIP] added remaining primitive type vectorization and tests * [WIP] unused imports fixed * Add argument validation to HadoopTables#create (#298) * Install source JAR when running install target (#310) * Bump version to 1.0-adobe-3.0-vectorized-SNAPSHOT * Temporarily ignore applying style check * Fixing javadoc error * Updating versions.lock * fixed checkstyle errors * Revert "Bump version to 1.0-adobe-3.0-vectorized-SNAPSHOT" This reverts commit ceae2fd. * cleanup
danielcweeks
pushed a commit
that referenced
this pull request
Aug 1, 2019
* Add argument validation to HadoopTables#create (#298) * Install source JAR when running install target (#310) * Add projectStrict for Dates and Timestamps (#283) * Correctly publish artifacts on JitPack (#321) The Gradle install target produces invalid POM files that are missing the dependencyManagement section and versions for some dependencies. Instead, we directly tell JitPack to run the correct Gradle target. * Add build info to README.md (#304) * Convert Iceberg time type to Hive string type (#325) * Add overwrite option to write builders (#318) * Fix out of order Pig partition fields (#326) * Add mapping to Iceberg for external name-based schemas (#338) * Site: Fix broken link to Iceberg API (#333) * Add forTable method for Avro WriteBuilder (#322) * Remove multiple literal strings check rule for scala (#335) * Fix invalid javadoc url in README.md (#336) * Use UnicodeUtil.truncateString for Truncate transform. (#340) This truncates by unicode codepoint instead of Java chars. * Refactor metrics tests for reuse (#331) * Spark: Add support for write-audit-publish workflows (#342) * Avoid write failures if metrics mode is invalid (#301) * Fix truncateStringMax in UnicodeUtil (#334) Fixes #328, fixes #329. Index to codePointAt should be the offset calculated by code points * [Vectorization] Added batch sizing, switched to BufferAllocator, other minor style fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.