Fix truncateStringMax in UnicodeUtil.#334
Closed
vgankidi wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
…the offset calculated by code points
Contributor
Contributor
Author
|
Also with the fix in #329, output of @ikosyanenko Can you test your long input in #328 with this fix as well? Thanks! |
Contributor
|
Looks like this needs to be rebased. |
rdblue
pushed a commit
that referenced
this pull request
Aug 1, 2019
Contributor
|
I rebased and merged by hand, so I'm closing this. Thanks for fixing it, @vgankidi! |
danielcweeks
pushed a commit
that referenced
this pull request
Aug 1, 2019
* Add argument validation to HadoopTables#create (#298) * Install source JAR when running install target (#310) * Add projectStrict for Dates and Timestamps (#283) * Correctly publish artifacts on JitPack (#321) The Gradle install target produces invalid POM files that are missing the dependencyManagement section and versions for some dependencies. Instead, we directly tell JitPack to run the correct Gradle target. * Add build info to README.md (#304) * Convert Iceberg time type to Hive string type (#325) * Add overwrite option to write builders (#318) * Fix out of order Pig partition fields (#326) * Add mapping to Iceberg for external name-based schemas (#338) * Site: Fix broken link to Iceberg API (#333) * Add forTable method for Avro WriteBuilder (#322) * Remove multiple literal strings check rule for scala (#335) * Fix invalid javadoc url in README.md (#336) * Use UnicodeUtil.truncateString for Truncate transform. (#340) This truncates by unicode codepoint instead of Java chars. * Refactor metrics tests for reuse (#331) * Spark: Add support for write-audit-publish workflows (#342) * Avoid write failures if metrics mode is invalid (#301) * Fix truncateStringMax in UnicodeUtil (#334) Fixes #328, fixes #329. Index to codePointAt should be the offset calculated by code points * [Vectorization] Added batch sizing, switched to BufferAllocator, other minor style fixes.
Contributor
Author
|
Thanks @rdblue! |
rdblue
pushed a commit
to rdblue/iceberg
that referenced
this pull request
Aug 22, 2019
Fixes apache#328, fixes apache#329. Index to codePointAt should be the offset calculated by code points
rdblue
pushed a commit
to rdblue/iceberg
that referenced
this pull request
Sep 5, 2019
Fixes apache#328, fixes apache#329. Index to codePointAt should be the offset calculated by code points
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Index to codePointAt should be the offset calculated by code points.
I incorrectly assumed that the index in codePointAt(index) refers to the index in terms of code points. It actually refers to the index of characters in the string.
resolves #328 #329