Conversation
| Iceberg is built using Gradle 5.2.1. | ||
|
|
||
| * To invoke a build and run tests, run: ./gradlew build | ||
| * To skip tests, run: ./gradlew build -x test |
There was a problem hiding this comment.
Next to skipping tests we could also document how to skip checkstyle violations (it usually helps lower the barrier for trying code changes) ./gradlew clean build -x test -x check. Wdyt?
There was a problem hiding this comment.
Checkstyle violations will be caught in CI testing and block PRs, so I'm not sure that excluding that check is a good idea. Maybe just note that this is okay for development, but will cause PRs to fail validation.
|
@timmylicheng you may need to close and reopen PR to trigger the CI again. |
timmylicheng
force-pushed
the
fix-issue-286
branch
from
fe03de3 to
da11d99
Compare
timmylicheng
force-pushed
the
fix-issue-286
branch
from
da11d99 to
eaff12f
Compare
|
|
||
| Iceberg is built using Gradle 5.2.1. | ||
|
|
||
| * To invoke a build and run tests, run: ./gradlew build |
There was a problem hiding this comment.
This will look nicer if you use code formatting (backticks):
* To invoke a build and run tests, run: `./gradlew build`
I'd also simplify it by removing the ", run" part on all of these:
* To invoke a build and run tests: `./gradlew build`
It will look like this when rendered:
- To invoke a build and run tests:
./gradlew build
There was a problem hiding this comment.
Kk. I will update it.
timmylicheng
force-pushed
the
fix-issue-286
branch
from
eaff12f to
85a63de
Compare
| Iceberg is built using Gradle 5.2.1. | ||
|
|
||
| * To invoke a build and run tests: `./gradlew build` | ||
| * To locally check sanity: `./gradlew check` |
There was a problem hiding this comment.
What do you mean? I see CI is using ./gradlew check.
There was a problem hiding this comment.
"check sanity" isn't a very clear description of why someone would use this task. Maybe it would be better to keep it simple and have just ./gradlew build and ./gradlew build -x test.
| * To invoke a build and run tests: `./gradlew build` | ||
| * To locally check sanity: `./gradlew check` | ||
| * To skip tests: `./gradlew build -x test` | ||
| * To skip tests and checkstyle (make sure you mean it): `./gradlew clean build -x test -x check` |
There was a problem hiding this comment.
Let's remove this. I think it is clear how to skip steps from the -x test example. The note that checkstyle is run in CI and PRs will fail is needed if this is here, but seems needlessly long to me.
There was a problem hiding this comment.
Ok.
I personally tried build without checkstyle initially. So when @fbocse brought it up, I thought maybe new users would wanna know.
timmylicheng
force-pushed
the
fix-issue-286
branch
from
85a63de to
0952738
Compare
timmylicheng
force-pushed
the
fix-issue-286
branch
from
0952738 to
c99da08
Compare
|
Merged. Thanks for contributing this, @timmylicheng! |
* Add argument validation to HadoopTables#create (#298) * Install source JAR when running install target (#310) * Add projectStrict for Dates and Timestamps (#283) * Correctly publish artifacts on JitPack (#321) The Gradle install target produces invalid POM files that are missing the dependencyManagement section and versions for some dependencies. Instead, we directly tell JitPack to run the correct Gradle target. * Add build info to README.md (#304) * Convert Iceberg time type to Hive string type (#325) * Add overwrite option to write builders (#318) * Fix out of order Pig partition fields (#326) * Add mapping to Iceberg for external name-based schemas (#338) * Site: Fix broken link to Iceberg API (#333) * Add forTable method for Avro WriteBuilder (#322) * Remove multiple literal strings check rule for scala (#335) * Fix invalid javadoc url in README.md (#336) * Use UnicodeUtil.truncateString for Truncate transform. (#340) This truncates by unicode codepoint instead of Java chars. * Refactor metrics tests for reuse (#331) * Spark: Add support for write-audit-publish workflows (#342) * Avoid write failures if metrics mode is invalid (#301) * Fix truncateStringMax in UnicodeUtil (#334) Fixes #328, fixes #329. Index to codePointAt should be the offset calculated by code points * [Vectorization] Added batch sizing, switched to BufferAllocator, other minor style fixes.
5 participants
#286