Spark - Update commands for running JMH tests with Spark 3.2 JMH #4328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbendick
commented
Mar 15, 2022
| * -PjmhOutputPath=benchmark/iceberg-source-parquet-with-unrelated-delete-benchmark-result.txt | ||
| * ./gradlew :iceberg-spark:iceberg-spark-3.2:jmh | ||
| * -PjmhIncludeRegex=IcebergSourceParquetWithUnrelatedDeleteBenchmark | ||
| * -PjmhOutputPath=benchmark/iceberg-source-parquet-with-unrelated-delete-benchmark-result.txt |
Contributor
Author
There was a problem hiding this comment.
Moved these out to match the formatting of the other existing javadoc comments.
Contributor
Author
kbendick
force-pushed
the
update-jmh-javadoc-command-instructions-spark-3.2
branch
from
113fbbc to
087b7b7
Compare
nastra
approved these changes
Mar 15, 2022
Contributor
|
Thanks for the updated. LGTM |
rdblue
approved these changes
Mar 16, 2022
Contributor
|
Thanks, @kbendick! |
This was referenced Mar 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The javadoc for the JMH tests references the old syntax, from prior to Iceberg 0.13.0 when we separated the code base by Spark versions.
Updating this as it came up in another PR.