Spark - Update commands for running Spark 3.1 JMH Benchmarks #4408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbendick
force-pushed
the
update-spark31-jmh-commnds
branch
from
81685d3 to
93222dd
Compare
rdblue
approved these changes
Mar 27, 2022
Contributor
|
Thanks, @kbendick! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #4328, the Spark JMH benchmarks have invalid commands in their JavaDoc comment ever since we migrated to version specific Spark builds.
This updates all of the Spark 3.1 tests to use the correct project
iceberg-spark-3.1_2.12:jmhas well as pass the system propertysparkVersions=3.1, as it's not included in the default Spark versions in our gradle configuration.cc @rdblue who reviewed the last one.