-
Notifications
You must be signed in to change notification settings - Fork 3k
Docs: add Cloudera native docs section #4536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
PR for the iceberg-docs: apache/iceberg-docs#72 |
docs/cloudera/_index.md
Outdated
| title: "Cloudera" | ||
| bookIconImage: ../img/cloudera-logo.png | ||
| bookFlatSection: true | ||
| weight: 410 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want a different weight for navbar items and this is the same weight as Trino. Maybe make this 415?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, will change it. Maybe worth adding a comment in a readme so that others will know about this requirement too? (unless this becomes obsolete with the new docs page design anyways)
| bookIconImage: ../img/cloudera-logo.png | ||
| bookFlatSection: true | ||
| weight: 415 | ||
| bookExternalUrlNewWindow: https://docs.cloudera.com/cdp/latest/cdp-iceberg/topics/iceberg-in-cdp.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to link to vendor docs rather than to the open source docs for Impala and Hive?
This seems like it doesn't fit with the current set of links, which are links to projects rather than to companies. Maybe we could use a "vendor" page to link instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are currently working on updating the docs:
- One part of it is updating the OS docs - which is a bigger task. We plan to keep most of the info here, as our strategy is OS first, as always. Our doc team is currently working on putting this together
- Also we would like to add a single link in the group of the vendor specific docs, which would point to the CDPD. Similarly as we (Iceberg community) did in case of other vendors:
What do you think @rdblue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is slightly different. Dremio, EMR, and Athena are all compute engines, but Cloudera isn't. It would make more sense to me to link to Impala and Hive docs than to link directly to Cloudera's platform (good to hear those are coming). That's why I would suggest having a Vendor section if we want to add Cloudera.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ryan! I think having a Vendor section would make sense. Is there any way I can help with that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marton-bod Here's the worksheet for the proposal from the community sync this week for the new docs site flow. You can find the diagram in there so feel free to add some comments/suggestions on adding a vendor section and where it would be fit into the logical flow of the site. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm making some style changes to the landing-page theme such as this PR, and I'll follow-up with a PR that includes a simple left navbar. Then we can add non-versioned pages incrementally there and a vendor page would actually be a good first candidate since such a page doesn't exist yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samredai: How could we help to move forward with the Vendor page? I would be happy to help any possible way.
Tried to ask write permission for the layout spreadsheet to add the page to the list, but no answer yet.
Thanks,
Peter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samredai: Ryan merged the Cloudera icon - could we move forward with the Vendor page as well? How could I help?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pvary sorry I was combing through my notifications and realized I missed this one. We should be good to add the vendors page now that the new theme is in. We just need to add a vendors.md file to the landing-page site in the common directory.
I'm thinking something simple like the graphql "Services" section. where it's a hyper-linked title (with alternative links, i.e. GitHub) on the left and a short description on the right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @samredai.
I am on a longer PTO, but maybe @szlta, or @lcspinter will be able to pick this up next week
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
Adding Cloudera to the Iceberg docs page.
I will open a separate PR for iceberg-docs to add the thumbnail image too