-
Notifications
You must be signed in to change notification settings - Fork 3k
Docs: add Cloudera native docs section #4536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| --- | ||
| title: "Cloudera" | ||
| bookIconImage: ../img/cloudera-logo.png | ||
| bookFlatSection: true | ||
| weight: 415 | ||
| bookExternalUrlNewWindow: https://docs.cloudera.com/cdp/latest/cdp-iceberg/topics/iceberg-in-cdp.html | ||
| --- | ||
| <!-- | ||
| - Licensed to the Apache Software Foundation (ASF) under one or more | ||
| - contributor license agreements. See the NOTICE file distributed with | ||
| - this work for additional information regarding copyright ownership. | ||
| - The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| - (the "License"); you may not use this file except in compliance with | ||
| - the License. You may obtain a copy of the License at | ||
| - | ||
| - http://www.apache.org/licenses/LICENSE-2.0 | ||
| - | ||
| - Unless required by applicable law or agreed to in writing, software | ||
| - distributed under the License is distributed on an "AS IS" BASIS, | ||
| - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| - See the License for the specific language governing permissions and | ||
| - limitations under the License. | ||
| --> | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to link to vendor docs rather than to the open source docs for Impala and Hive?
This seems like it doesn't fit with the current set of links, which are links to projects rather than to companies. Maybe we could use a "vendor" page to link instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are currently working on updating the docs:
What do you think @rdblue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is slightly different. Dremio, EMR, and Athena are all compute engines, but Cloudera isn't. It would make more sense to me to link to Impala and Hive docs than to link directly to Cloudera's platform (good to hear those are coming). That's why I would suggest having a Vendor section if we want to add Cloudera.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ryan! I think having a Vendor section would make sense. Is there any way I can help with that?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marton-bod Here's the worksheet for the proposal from the community sync this week for the new docs site flow. You can find the diagram in there so feel free to add some comments/suggestions on adding a vendor section and where it would be fit into the logical flow of the site. 👍
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm making some style changes to the landing-page theme such as this PR, and I'll follow-up with a PR that includes a simple left navbar. Then we can add non-versioned pages incrementally there and a vendor page would actually be a good first candidate since such a page doesn't exist yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samredai: How could we help to move forward with the Vendor page? I would be happy to help any possible way.
Tried to ask write permission for the layout spreadsheet to add the page to the list, but no answer yet.
Thanks,
Peter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samredai: Ryan merged the Cloudera icon - could we move forward with the Vendor page as well? How could I help?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pvary sorry I was combing through my notifications and realized I missed this one. We should be good to add the vendors page now that the new theme is in. We just need to add a
vendors.mdfile to the landing-page site in the common directory.I'm thinking something simple like the graphql "Services" section. where it's a hyper-linked title (with alternative links, i.e. GitHub) on the left and a short description on the right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @samredai.
I am on a longer PTO, but maybe @szlta, or @lcspinter will be able to pick this up next week