Core: Remove TableOperations from metadata tables. #6357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdblue
force-pushed
the
core-remove-ops-from-metadata-tables
branch
2 times, most recently
from
b8fbba7 to
f9ed0d0
Compare
szehon-ho
approved these changes
Jan 9, 2023
Member
szehon-ho
left a comment
szehon-ho
left a comment
There was a problem hiding this comment.
Looks good to me. I guess it also as a consequence removes TableOperations from the BaseTableScan hierarchy, but seems to me a good simplification if we never needed it there.
| @Override | ||
| public FileIO io() { | ||
| return operations().io(); | ||
| return ops.io(); |
Member
There was a problem hiding this comment.
These are unrelated , and just simplification/standardization, right? Fine with me either way
Contributor
Author
There was a problem hiding this comment.
Where possible, I removed references to methods that expose TableOperations and deprecated the methods.
Here in BaseTable, I just wanted to be more consistent and use the instance field directly.
Contributor
|
@rdblue looks like this needs some RevAPI changes because the APIs changed |
rdblue
force-pushed
the
core-remove-ops-from-metadata-tables
branch
from
f9ed0d0 to
de03fc7
Compare
Contributor
Author
|
Thanks for the review, @szehon-ho! |
krvikash
pushed a commit
to krvikash/iceberg
that referenced
this pull request
Mar 16, 2023
zhongyujiang
pushed a commit
to zhongyujiang/iceberg
that referenced
this pull request
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the use of
TableOperationsfrom metadata tables. WhereTableMetadatais needed, operations is fetched from theTableinstance instead of passing the ops explicitly. This is in preparation for metadata tables that are not tied to a particular Iceberg table.