Skip to content

Conversation

@rdblue
Copy link
Contributor

@rdblue rdblue commented Jan 16, 2023

This is based on #6357 and will be rebased once that PR is merged.

This adds information_schema.namespaces and base classes for creating new information_schema tables. Namespace filtering is implemented to avoid too many queries against catalogs.

@rdblue rdblue marked this pull request as draft January 16, 2023 00:11
@rdblue rdblue force-pushed the core-add-information-schema-tables branch from dc6f736 to 2964627 Compare January 16, 2023 21:37
@aokolnychyi
Copy link
Contributor

@rdblue, could you rebase? I can review.

* @param ids field IDs used to match predicates to extract from the expression
* @return an Expression that selects at least the same rows as the original using only the IDs
*/
public static Expression extractByIdInclusive(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been already merged in #6716.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the tests were missing. I'll add those when I clean this up.

@github-actions
Copy link

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Aug 24, 2024
@github-actions
Copy link

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants