Python: Use Version Ranges for Various Dependencies#6745
Merged
Conversation
e7b9004 to
06f7467
Compare
Contributor
Author
|
Ready for review. @Fokko or someone else? |
Fokko
reviewed
Feb 8, 2023
| thrift = { version = "0.16.0", optional = true } | ||
|
|
||
| boto3 = {version = "1.24.59", optional = true} | ||
| boto3 = { version = "1.24.59", optional = true } |
Contributor
There was a problem hiding this comment.
Would be cool if we can get some kind of TOML linter.
krvikash
pushed a commit
to krvikash/iceberg
that referenced
this pull request
Mar 16, 2023
This was referenced Mar 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #6620, this PR uses version ranges for some dependencies. This will unfix the versions for certain dependencies and allow users to use older versions when install PyIceberg to use as a library. The dependencies changed are:
11.0.0to8.0.0-11.0.0. It is an optional dependency used either for FileIO, conversion from Iceberg to Arrow (schema, expression, table, etc.), or a dep for Pandas or DuckDB. Made sure current tests pass with every major version.1.5.3to1.4.4-1.5.3. It is only used to read Iceberg tables out to Pandas, which is current done through PyArrow anyways. Tested 1.4.4. PyIceberg used 1.5.2 until recently0.6.1to0.6.0-0.6.1. Similar to Pandas, and PyIceberg used 0.6.0 until recently2023.1.0to2022.8.2-2023.1.0. Used for FileIO, and I believe S3Fs and ADLSFs already depend on the same version of FsSpec. Tested with all major versions with success, and PyIceberg has used2022.8.2,2022.10.0, and2022.11.2in the past2.28.2to2.28.1-2.28.2since this is only a patch release and PyIceberg used2.28.1until recently.13.3.1to13.0.0-13.3.1since this is minor release changes with no significant differences6.0.0to5.4.0-6.0.0since5.4is still used commonly in other tools, and the only change in the major change in the major release was removing Python 2.7 support. Tested with5.4.0