Skip to content

Python: Relax the pin for fsspec implementations#7242

Merged
Fokko merged 1 commit into
apache:masterfrom
deepyaman:python/upgrade-fsspec
Mar 31, 2023
Merged

Python: Relax the pin for fsspec implementations#7242
Fokko merged 1 commit into
apache:masterfrom
deepyaman:python/upgrade-fsspec

Conversation

@deepyaman
Copy link
Copy Markdown
Contributor

I'm proposing a minimal change to relax fsspec, s3fs, adlfs again (after #6745 relaxed a bit).

Specifically, I want to be able to leverage fsspec/s3fs#704 (or fsspec/filesystem_spec#1194) to provide the endpoint URL. Previously, I was doing something custom:

-        load_catalog(
-            "default",
-            **{
-                "s3.endpoint": os.environ.get("PYICEBERG_CATALOG__DEFAULT__S3_ENDPOINT")
-            },
-        )
+        load_catalog("default")

However, since asking about this on Slack, I've found that most environment variables will be read by pyiceberg by way of s3fs (e.g. AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY), and that fsspec/s3fs have recently provided (better) ways to even configure endpoint URL. So I'd like to leverage them. :)

As somebody developing a library that has a dependency on pyiceberg, there's a broader issue of not pinning versions so tightly, but I will create a separate issue on that.

Copy link
Copy Markdown
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any problem in relaxing the version here. Thanks for opening this PR @deepyaman

@Fokko Fokko merged commit 885c47b into apache:master Mar 31, 2023
@deepyaman deepyaman deleted the python/upgrade-fsspec branch March 31, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants