Add support for single json dict environment variable for protocol#1194
Merged
Conversation
Member
|
Thanks for working on this! |
timsnyder
reviewed
Feb 26, 2023
Contributor
timsnyder
left a comment
timsnyder
left a comment
There was a problem hiding this comment.
some logging of the silently dropped cases might be helpful. I know it would help me as a user.
timsnyder
reviewed
Feb 26, 2023
Co-authored-by: Tim Snyder <snyder.tim@gmail.com>
mauvilsa
requested review from
martindurant and
timsnyder
and removed request for
martindurant and
timsnyder
Member
|
Thank you! |
agoodm
pushed a commit
to agoodm/filesystem_spec
that referenced
this pull request
Mar 14, 2023
…sspec#1194) * Add support for single json dict environment variable for protocol. * Update docs/source/features.rst Co-authored-by: Tim Snyder <snyder.tim@gmail.com> * Add warnings when environment variables are ignored. --------- Co-authored-by: Tim Snyder <snyder.tim@gmail.com>
This was referenced Mar 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #1130.