Flink: switch to FileScanTaskParser for JSON serialization of IcebergSourceSplit#7978
Merged
stevenzwu merged 3 commits intoapache:masterfrom Jul 8, 2023
Merged
Flink: switch to FileScanTaskParser for JSON serialization of IcebergSourceSplit#7978stevenzwu merged 3 commits intoapache:masterfrom
stevenzwu merged 3 commits intoapache:masterfrom
Conversation
pvary
approved these changes
Jul 4, 2023
nastra
approved these changes
Jul 5, 2023
Contributor
nastra
left a comment
nastra
left a comment
There was a problem hiding this comment.
LGTM, but I left a comment around error msg clarity
|
|
||
| Preconditions.checkArgument( | ||
| writtenTasks == fileScanTasks.size(), | ||
| "Invalid combined scan task: collection size = %s, iterator size = %s", |
Contributor
There was a problem hiding this comment.
I'm not sure it's clear to a reader what the difference between collection size and iterator size is
Contributor
Author
There was a problem hiding this comment.
totally agree. removed this unnecessary check and simplified the loop.
…e/split/IcebergSourceSplit.java Co-authored-by: Eduard Tudenhoefner <etudenhoefner@gmail.com>
Contributor
Author
|
issue #1698 |
Contributor
Author
stevenzwu
added a commit
to stevenzwu/iceberg
that referenced
this pull request
Aug 4, 2023
… serialization of IcebergSourceSplit
stevenzwu
added a commit
that referenced
this pull request
Aug 10, 2023
…lization of IcebergSourceSplit (#8228)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.