Skip to content

Flink: backport PR #7978. switch to FileScanTaskParser for JSON serialization of IcebergSourceSplit#8228

Merged
stevenzwu merged 1 commit intoapache:masterfrom
stevenzwu:backport-7978
Aug 10, 2023
Merged

Flink: backport PR #7978. switch to FileScanTaskParser for JSON serialization of IcebergSourceSplit#8228
stevenzwu merged 1 commit intoapache:masterfrom
stevenzwu:backport-7978

Conversation

@stevenzwu
Copy link
Copy Markdown
Contributor

it is a clean back port.

confirmed git diff

➜  iceberg git:(backport-7978) ✗ git diff --no-index  flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/source  flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source
➜  iceberg git:(backport-7978) ✗ git diff --no-index  flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/source  flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source

test folder has some diff related to assertj change, not related to this change

➜  iceberg git:(backport-7978) ✗ git diff --no-index  flink/v1.15/flink/src/test/java/org/apache/iceberg/flink/source  flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source
➜  iceberg git:(backport-7978) ✗ git diff --no-index  flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/source  flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source

@stevenzwu stevenzwu requested a review from pvary August 4, 2023 18:01
@github-actions github-actions Bot added the flink label Aug 4, 2023
Copy link
Copy Markdown
Contributor

@ConeyLiu ConeyLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for backport

@stevenzwu stevenzwu merged commit b033de7 into apache:master Aug 10, 2023
@stevenzwu
Copy link
Copy Markdown
Contributor Author

thanks @pvary and @ConeyLiu for reviews

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants