Thread.sleep() method is replaced with Awaitility #8725
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nk1506
suggested changes
Oct 6, 2023
.../v1.15/flink/src/test/java/org/apache/iceberg/flink/source/TestStreamingMonitorFunction.java
Outdated
Show resolved
Hide resolved
.../v1.15/flink/src/test/java/org/apache/iceberg/flink/source/TestStreamingMonitorFunction.java
Outdated
Show resolved
Hide resolved
...k/v1.16/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceContinuous.java
Outdated
Show resolved
Hide resolved
Author
nastra
reviewed
Oct 6, 2023
| Assert.assertTrue( | ||
| "Should have expected elements.", latch.await(WAIT_TIME_MILLIS, TimeUnit.MILLISECONDS)); | ||
| Thread.sleep(1000L); | ||
| Awaitility.await().atLeast(1, TimeUnit.SECONDS).until(() -> true); |
Contributor
There was a problem hiding this comment.
this goes back to my earlier comment here. We don't want to blindly just change Thread.sleep usage to Awaitility
Author
There was a problem hiding this comment.
I am new to open source , will it be ok if i replace this with simply Awaitility.await()
.atMost(WAIT_TIME_MILLIS, TimeUnit.MILLISECONDS)
.pollInterval(100, TimeUnit.MILLISECONDS)
.until(() -> latch.getCount() == 0); @nastra or suggest changes please.
Contributor
There was a problem hiding this comment.
@shreyanshR7 , I also tried to make a fix for this here . You can still continue on flink module.
Contributor
|
Closing this one as it has been superseded by #8804 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nastra