Spark 3.5: Use Awaitility instead of Thread.sleep() #8853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nk1506
reviewed
Oct 17, 2023
| } catch (InterruptedException e) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| Awaitility.await() |
Contributor
There was a problem hiding this comment.
nit: is it a good idea to add some alias with Awaitility here?
Contributor
Author
There was a problem hiding this comment.
in certain cases it makes sense to add an alias, but here I think we should be ok, since there's a comment right above that explains what's being done
amogh-jahagirdar
approved these changes
Oct 17, 2023
Contributor
amogh-jahagirdar
left a comment
amogh-jahagirdar
left a comment
There was a problem hiding this comment.
LGTM thanks Eduard!
This was referenced Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.