Skip to content

fix(ci): prevent v8/musl build failures in artifacts and Docker#2844

Merged
mmodzelewski merged 1 commit intomasterfrom
fix-ci-deno
Mar 2, 2026
Merged

fix(ci): prevent v8/musl build failures in artifacts and Docker#2844
mmodzelewski merged 1 commit intomasterfrom
fix-ci-deno

Conversation

@hubcio
Copy link
Contributor

@hubcio hubcio commented Mar 2, 2026

charming's "ssr" feature pulls deno_core -> rusty_v8, which
has no prebuilt static libraries for any musl target. The
bench-dashboard exclusion only covered aarch64-musl, leaving
x86_64-musl broken after #2833 added the ssr feature.

Extend the musl exclusion to all musl targets in the artifact
build. Scope each Dockerfile's cargo-chef cook to only the
packages it ships (-p), avoiding workspace-wide feature
unification that drags in v8 for images that never use it.

charming's "ssr" feature pulls deno_core -> rusty_v8, which
has no prebuilt static libraries for any musl target. The
bench-dashboard exclusion only covered aarch64-musl, leaving
x86_64-musl broken after #2833 added the ssr feature.

Extend the musl exclusion to all musl targets in the artifact
build. Scope each Dockerfile's cargo-chef cook to only the
packages it ships (-p), avoiding workspace-wide feature
unification that drags in v8 for images that never use it.
@codecov
Copy link

codecov bot commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.67%. Comparing base (effbab6) to head (2d56b69).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2844      +/-   ##
============================================
- Coverage     67.68%   67.67%   -0.02%     
  Complexity      739      739              
============================================
  Files          1031     1031              
  Lines         83912    83912              
  Branches      60704    60715      +11     
============================================
- Hits          56799    56790       -9     
+ Misses        24768    24760       -8     
- Partials       2345     2362      +17     
Flag Coverage Δ
csharp 67.06% <ø> (-0.19%) ⬇️
go 6.84% <ø> (ø)
java 54.83% <ø> (ø)
node 92.26% <ø> (-0.07%) ⬇️
python 0.00% <ø> (ø)
rust 69.71% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 21 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mmodzelewski mmodzelewski merged commit ab8834d into master Mar 2, 2026
71 checks passed
@mmodzelewski mmodzelewski deleted the fix-ci-deno branch March 2, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants