fix(ci): prevent v8/musl build failures in artifacts and Docker#2844
Merged
mmodzelewski merged 1 commit intomasterfrom Mar 2, 2026
Merged
fix(ci): prevent v8/musl build failures in artifacts and Docker#2844mmodzelewski merged 1 commit intomasterfrom
mmodzelewski merged 1 commit intomasterfrom
Conversation
charming's "ssr" feature pulls deno_core -> rusty_v8, which has no prebuilt static libraries for any musl target. The bench-dashboard exclusion only covered aarch64-musl, leaving x86_64-musl broken after #2833 added the ssr feature. Extend the musl exclusion to all musl targets in the artifact build. Scope each Dockerfile's cargo-chef cook to only the packages it ships (-p), avoiding workspace-wide feature unification that drags in v8 for images that never use it.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2844 +/- ##
============================================
- Coverage 67.68% 67.67% -0.02%
Complexity 739 739
============================================
Files 1031 1031
Lines 83912 83912
Branches 60704 60715 +11
============================================
- Hits 56799 56790 -9
+ Misses 24768 24760 -8
- Partials 2345 2362 +17
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
mmodzelewski
approved these changes
Mar 2, 2026
spetz
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
charming's "ssr" feature pulls deno_core -> rusty_v8, which
has no prebuilt static libraries for any musl target. The
bench-dashboard exclusion only covered aarch64-musl, leaving
x86_64-musl broken after #2833 added the ssr feature.
Extend the musl exclusion to all musl targets in the artifact
build. Scope each Dockerfile's cargo-chef cook to only the
packages it ships (-p), avoiding workspace-wide feature
unification that drags in v8 for images that never use it.