Skip to content

MINOR: the request thread in clientToControllerChannelManager is NOT…#10347

Closed
chia7712 wants to merge 1 commit intoapache:trunkfrom
chia7712:MINOR-10347
Closed

MINOR: the request thread in clientToControllerChannelManager is NOT…#10347
chia7712 wants to merge 1 commit intoapache:trunkfrom
chia7712:MINOR-10347

Conversation

@chia7712
Copy link
Copy Markdown
Member

I noticed this issue when running system tests. Most raft-related tests fails.

related to #10135

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@chia7712 chia7712 requested review from abbccdda and hachikuji March 18, 2021 06:26
@chia7712 chia7712 marked this pull request as draft March 18, 2021 06:29
@chia7712
Copy link
Copy Markdown
Member Author

convert to draft as alterIsrManager.start() can start the request thread... will dig in it again.

@chia7712 chia7712 changed the title HOTFIX: the request thread in clientToControllerChannelManager is NOT… MINOR: the request thread in clientToControllerChannelManager is NOT… Mar 18, 2021
@chia7712
Copy link
Copy Markdown
Member Author

convert to draft as alterIsrManager.start() can start the request thread... will dig in it again.

ugh, alterIsrManager take another BrokerToControllerChannelManager. ok. we do need to start the clientToControllerChannelManager

@chia7712 chia7712 marked this pull request as ready for review March 18, 2021 06:46
@dengziming
Copy link
Copy Markdown
Member

It seems that this issue has been fixed by #10340.

@chia7712
Copy link
Copy Markdown
Member Author

It seems that this issue has been fixed by #10340.

You are right :)

close this now.

@chia7712 chia7712 closed this Mar 18, 2021
@chia7712 chia7712 deleted the MINOR-10347 branch March 25, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants