KAFKA-10348: Share client channel between forwarding and auto creation manager#10135
Merged
abbccdda merged 3 commits intoapache:trunkfrom Mar 15, 2021
Merged
Conversation
dengziming
reviewed
Feb 17, 2021
abbccdda
force-pushed
the
consolidate-forwarding-channel-KAFKA-10348
branch
2 times, most recently
from
67ce24b to
06ae463
Compare
abbccdda
force-pushed
the
consolidate-forwarding-channel-KAFKA-10348
branch
from
06ae463 to
3677cb7
Compare
hachikuji
reviewed
Mar 12, 2021
abbccdda
force-pushed
the
consolidate-forwarding-channel-KAFKA-10348
branch
from
ca2c1af to
cebf64c
Compare
hachikuji
approved these changes
Mar 12, 2021
Contributor
hachikuji
left a comment
hachikuji
left a comment
There was a problem hiding this comment.
LGTM. One small naming suggestion.
| metrics, | ||
| config, | ||
| channelName = "forwarding", | ||
| channelName = "clientToControllerChannel", |
Contributor
There was a problem hiding this comment.
How about "controllerForwardingChannel"? I think it fits for both cases we're handling.
3 tasks
ijuma
added a commit
to confluentinc/kafka
that referenced
this pull request
Mar 17, 2021
Conflicts: * Jenkinsfile: `install` -> `publishToMavenLocal`, drop ARM build and other changes that don't make sense for Confluent's version of `Jenkinsfile`. * build.gradle: keep Confluent changes for automatic skipping signing for specific version patterns (upstream only does it if the version ends with `SNAPSHOT`). Commits: * apache-github/trunk: (59 commits) MINOR: Remove redundant allows in import-control.xml (apache#10339) MINOR: remove some specifying types in tool command (apache#10329) KAFKA-12455: Fix OffsetValidationTest.test_broker_rolling_bounce failure with Raft (apache#10322) MINOR: Add toString to various Kafka Metrics classes (apache#10330) KAFKA-12330; FetchSessionCache may cause starvation for partitions when FetchResponse is full (apache#10318) KAFKA-12427: Don't update connection idle time for muted connections (apache#10267) MINOR; Various code cleanups (apache#10319) HOTFIX: timeout issue in removeStreamThread() (apache#10321) revert stream logging level back to ERROR (apache#10320) KAFKA-12352: Make sure all rejoin group and reset state has a reason (apache#10232) KAFKA-10348: Share client channel between forwarding and auto creation manager (apache#10135) MINOR: Update year in NOTICE (apache#10308) KAFKA-12398: Fix flaky test `ConsumerBounceTest.testClose` (apache#10243) MINOR: Remove redundant inheritance from FilteringJmxReporter #onMetricRemoved (apache#10303) KAFKA-12462: proceed with task revocation in case of thread in PENDING_SHUTDOWN (apache#10311) KAFKA-12460; Do not allow raft truncation below high watermark (apache#10310) MINOR: Log project, gradle, java and scala versions at the start of the build (apache#10307) KAFKA-10357: Add missing repartition topic validation (apache#10305) MINOR: Improve error message in MirrorConnectorsIntegrationBaseTest (apache#10268) MINOR: Add missing unit tests for Mirror Connect (apache#10192) ...
3 tasks
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to consolidate forwarding and auto creation channel into one channel to reduce the unnecessary connections maintained between brokers and controller.
Committer Checklist (excluded from commit message)