Skip to content

MINOR: Add toString to various Kafka Metrics classes#10330

Merged
ijuma merged 1 commit intoapache:trunkfrom
ijuma:kafka-metrics-to-string
Mar 16, 2021
Merged

MINOR: Add toString to various Kafka Metrics classes#10330
ijuma merged 1 commit intoapache:trunkfrom
ijuma:kafka-metrics-to-string

Conversation

@ijuma
Copy link
Copy Markdown
Member

@ijuma ijuma commented Mar 16, 2021

This was useful while debugging a JDK 16 test failure, I noticed these
were missing.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

This was useful while debugging a JDK 16 test failure, I noticed these
were missing.
@ijuma
Copy link
Copy Markdown
Member Author

ijuma commented Mar 16, 2021

@dajac any reason not to do this?

@ijuma ijuma requested review from chia7712 and dajac March 16, 2021 14:51
@dajac
Copy link
Copy Markdown
Member

dajac commented Mar 16, 2021

@ijuma I can't think of any reason not to do this. This seems reasonable to have.

Copy link
Copy Markdown
Member

@dajac dajac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ijuma
Copy link
Copy Markdown
Member Author

ijuma commented Mar 16, 2021

Failures are unrelated.

@ijuma ijuma merged commit 36c5ad4 into apache:trunk Mar 16, 2021
@ijuma ijuma deleted the kafka-metrics-to-string branch March 16, 2021 20:51
ijuma added a commit to confluentinc/kafka that referenced this pull request Mar 17, 2021
Conflicts:
* Jenkinsfile: `install` -> `publishToMavenLocal`, drop ARM build and
other changes that don't make sense for Confluent's version of
`Jenkinsfile`.
* build.gradle: keep Confluent changes for automatic skipping signing
for specific version patterns (upstream only does it if the version ends
with `SNAPSHOT`).

Commits:
* apache-github/trunk: (59 commits)
  MINOR: Remove redundant allows in import-control.xml (apache#10339)
  MINOR: remove some specifying types in tool command (apache#10329)
  KAFKA-12455: Fix OffsetValidationTest.test_broker_rolling_bounce failure with Raft (apache#10322)
  MINOR: Add toString to various Kafka Metrics classes (apache#10330)
  KAFKA-12330; FetchSessionCache may cause starvation for partitions when FetchResponse is full (apache#10318)
  KAFKA-12427: Don't update connection idle time for muted connections (apache#10267)
  MINOR; Various code cleanups (apache#10319)
  HOTFIX: timeout issue in removeStreamThread() (apache#10321)
  revert stream logging level back to ERROR (apache#10320)
  KAFKA-12352: Make sure all rejoin group and reset state has a reason (apache#10232)
  KAFKA-10348: Share client channel between forwarding and auto creation manager (apache#10135)
  MINOR: Update year in NOTICE (apache#10308)
  KAFKA-12398: Fix flaky test `ConsumerBounceTest.testClose` (apache#10243)
  MINOR: Remove redundant inheritance from FilteringJmxReporter #onMetricRemoved (apache#10303)
  KAFKA-12462: proceed with task revocation in case of thread in PENDING_SHUTDOWN (apache#10311)
  KAFKA-12460; Do not allow raft truncation below high watermark (apache#10310)
  MINOR: Log project, gradle, java and scala versions at the start of the build (apache#10307)
  KAFKA-10357: Add missing repartition topic validation (apache#10305)
  MINOR: Improve error message in MirrorConnectorsIntegrationBaseTest (apache#10268)
  MINOR: Add missing unit tests for Mirror Connect (apache#10192)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants