Skip to content

HOTFIX: timeout issue in Remove thread#10321

Merged
ableegoldman merged 1 commit intoapache:trunkfrom
wcarlson5:fix_timeout
Mar 16, 2021
Merged

HOTFIX: timeout issue in Remove thread#10321
ableegoldman merged 1 commit intoapache:trunkfrom
wcarlson5:fix_timeout

Conversation

@wcarlson5
Copy link
Copy Markdown
Contributor

@wcarlson5 wcarlson5 commented Mar 15, 2021

timeout is a duration not a point in time

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@wcarlson5
Copy link
Copy Markdown
Contributor Author

wcarlson5 commented Mar 15, 2021

@cadonna @ableegoldman Can I get a look at this?

@vvcephei This will need to be picked to 2.8 as well

cadonna
cadonna approved these changes Mar 15, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@cadonna cadonna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

Just one comment about the title. I guess "HOTFIX: " would be better than "Minor:".

For the rest, LGTM!

@wcarlson5 wcarlson5 changed the title Minor:timeout issue in Remove thread HOTFIX: timeout issue in Remove thread Mar 15, 2021
ableegoldman
ableegoldman approved these changes Mar 15, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@ableegoldman ableegoldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, LGTM

@wcarlson5 wcarlson5 requested a review from ableegoldman March 16, 2021 02:59
@ableegoldman
Copy link
Copy Markdown
Member

ableegoldman commented Mar 16, 2021

One unrelated flaky test failure (KAFKA-12283): connect.integration.RebalanceSourceConnectorsIntegrationTest.testMultipleWorkersRejoining

@ableegoldman ableegoldman merged commit 336d26a into apache:trunk Mar 16, 2021
@wcarlson5 wcarlson5 deleted the fix_timeout branch March 16, 2021 03:12
lct45 pushed a commit to confluentinc/kafka that referenced this pull request Mar 16, 2021
@wcarlson5
HOTFIX: timeout issue in removeStreamThread() (apache#10321)
8d66e47 
Timeout is a duration not a point in time.

Reviewers: Bruno Cadonna <cadonna@confluent.io>, Anna Sophie Blee-Goldman <ableegoldman@apache.org>
@wcarlson5
Copy link
Copy Markdown
Contributor Author

wcarlson5 commented Mar 16, 2021

@ableegoldman Can we cherry pick to 2.8 as well?

@cadonna
Copy link
Copy Markdown
Member

cadonna commented Mar 16, 2021

This decision should be taken by @vvcephei since he drives the 2.8 release.

@vvcephei
Copy link
Copy Markdown
Contributor

vvcephei commented Mar 16, 2021

Thanks @wcarlson5. Yes, please cherry-pick it to 2.8.

ableegoldman pushed a commit that referenced this pull request Mar 16, 2021
@wcarlson5 @ableegoldman
HOTFIX: timeout issue in removeStreamThread() (#10321)
aa303e8 
Timeout is a duration not a point in time.

Reviewers: Bruno Cadonna <cadonna@confluent.io>, Anna Sophie Blee-Goldman <ableegoldman@apache.org>
@ableegoldman
Copy link
Copy Markdown
Member

ableegoldman commented Mar 16, 2021

Cherrypicked to 2.8 cc @vvcephei

@ijuma ijuma mentioned this pull request Mar 17, 2021
Merged
3 tasks
ijuma added a commit to confluentinc/kafka that referenced this pull request Mar 17, 2021
@ijuma
CONFLUENT: Sync from apache/kafka/trunk (17 March 2021)
bea34ef 
Conflicts:
* Jenkinsfile: `install` -> `publishToMavenLocal`, drop ARM build and
other changes that don't make sense for Confluent's version of
`Jenkinsfile`.
* build.gradle: keep Confluent changes for automatic skipping signing
for specific version patterns (upstream only does it if the version ends
with `SNAPSHOT`).

Commits:
* apache-github/trunk: (59 commits)
  MINOR: Remove redundant allows in import-control.xml (apache#10339)
  MINOR: remove some specifying types in tool command (apache#10329)
  KAFKA-12455: Fix OffsetValidationTest.test_broker_rolling_bounce failure with Raft (apache#10322)
  MINOR: Add toString to various Kafka Metrics classes (apache#10330)
  KAFKA-12330; FetchSessionCache may cause starvation for partitions when FetchResponse is full (apache#10318)
  KAFKA-12427: Don't update connection idle time for muted connections (apache#10267)
  MINOR; Various code cleanups (apache#10319)
  HOTFIX: timeout issue in removeStreamThread() (apache#10321)
  revert stream logging level back to ERROR (apache#10320)
  KAFKA-12352: Make sure all rejoin group and reset state has a reason (apache#10232)
  KAFKA-10348: Share client channel between forwarding and auto creation manager (apache#10135)
  MINOR: Update year in NOTICE (apache#10308)
  KAFKA-12398: Fix flaky test `ConsumerBounceTest.testClose` (apache#10243)
  MINOR: Remove redundant inheritance from FilteringJmxReporter #onMetricRemoved (apache#10303)
  KAFKA-12462: proceed with task revocation in case of thread in PENDING_SHUTDOWN (apache#10311)
  KAFKA-12460; Do not allow raft truncation below high watermark (apache#10310)
  MINOR: Log project, gradle, java and scala versions at the start of the build (apache#10307)
  KAFKA-10357: Add missing repartition topic validation (apache#10305)
  MINOR: Improve error message in MirrorConnectorsIntegrationBaseTest (apache#10268)
  MINOR: Add missing unit tests for Mirror Connect (apache#10192)
  ...
vvcephei pushed a commit to confluentinc/kafka that referenced this pull request Mar 20, 2021
@wcarlson5
HOTFIX: timeout issue in removeStreamThread() (apache#10321)
69a5a18 
Timeout is a duration not a point in time.

Reviewers: Bruno Cadonna <cadonna@confluent.io>, Anna Sophie Blee-Goldman <ableegoldman@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cadonna cadonna cadonna approved these changes

@ableegoldman ableegoldman Awaiting requested review from ableegoldman

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wcarlson5 @ableegoldman @cadonna @vvcephei