KAFKA-12561: don't set timeout for future.get#10410
Merged
chia7712 merged 3 commits intoapache:trunkfrom Mar 31, 2021
Merged
Conversation
Member
Author
|
@mumrah , @hachikuji , could you review this PR? It failed a lot in recent builds. Thanks. |
Member
Author
|
@mumrah , @hachikuji , could you review this PR? It keeps failing recent builds. Thanks. |
Member
|
@showuon Could you merge trunk to trigger QA again? I'd like to merge it if QA pass :) |
Member
Author
|
@chia7712 , merged the trunk and tests triggered. Let's see :) |
Member
|
|
Member
|
@showuon thanks for this fix! |
Terrdi
pushed a commit
to Terrdi/kafka
that referenced
this pull request
Apr 1, 2021
…AndCreateListDeleteTopic (apache#10410) Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests failed quite often, because of
TimeoutException. We cannot get the future result in time. I think the flaky tests tell us that we should not expect the results will return as soon as we expected in jenkins. Like other tests, we don't usually set timeout when future.get, so remove the timeout setting to make this test reliable.Committer Checklist (excluded from commit message)