Skip to content

KAFKA-12561: don't set timeout for future.get#10410

Merged
chia7712 merged 3 commits intoapache:trunkfrom
showuon:KAFKA-12561
Mar 31, 2021
Merged

KAFKA-12561: don't set timeout for future.get#10410
chia7712 merged 3 commits intoapache:trunkfrom
showuon:KAFKA-12561

Conversation

@showuon
Copy link
Copy Markdown
Member

@showuon showuon commented Mar 26, 2021

These tests failed quite often, because of TimeoutException. We cannot get the future result in time. I think the flaky tests tell us that we should not expect the results will return as soon as we expected in jenkins. Like other tests, we don't usually set timeout when future.get, so remove the timeout setting to make this test reliable.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@showuon
Copy link
Copy Markdown
Member Author

showuon commented Mar 26, 2021

@mumrah , @hachikuji , could you review this PR? It failed a lot in recent builds. Thanks.

Copy link
Copy Markdown
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@showuon thanks for this quick fix. This patch makes sense to me. This class has a global timeout so removing the local timeout should be fine.

+1

@showuon
Copy link
Copy Markdown
Member Author

showuon commented Mar 31, 2021

@mumrah , @hachikuji , could you review this PR? It keeps failing recent builds. Thanks.

@chia7712
Copy link
Copy Markdown
Member

@showuon Could you merge trunk to trigger QA again? I'd like to merge it if QA pass :)

@showuon
Copy link
Copy Markdown
Member Author

showuon commented Mar 31, 2021

@chia7712 , merged the trunk and tests triggered. Let's see :)

@chia7712
Copy link
Copy Markdown
Member

kafka.server.ListOffsetsRequestTest.testResponseIncludesLeaderEpoch() is traced by #10389 and ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit is unrelated flaky. will merge to trunk

@chia7712 chia7712 merged commit 0981d25 into apache:trunk Mar 31, 2021
@chia7712
Copy link
Copy Markdown
Member

@showuon thanks for this fix!

@showuon showuon deleted the KAFKA-12561 branch March 31, 2021 06:03
Terrdi pushed a commit to Terrdi/kafka that referenced this pull request Apr 1, 2021
…AndCreateListDeleteTopic (apache#10410)

Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants