KAFKA-12779: KIP-740, Introduce public TaskId interface and TaskMetadata.id() API that returns it#10691
Closed
ableegoldman wants to merge 7 commits intoapache:trunkfrom
Closed
Conversation
Member
Author
|
I know this looks like it will be absolutely miserable to review since there are 109 files changed, but probably at least 100 of them are just one or two lines of change: inserting the new The only "real" changes are those listed in the PR description: the new and old TaskId classes plus the new TaskIdMetadata interface, and the new + deprecated APIs in TaskMetadata, ProcessorContext, and StateStoreContext. You should focus your review on those classes and skim (or even skip) the rest. |
Member
Author
|
Closed in favor of #10735 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the existing
TaskIdclass to theinternalspackage, and has it implement a newTaskIdinterface which just exposes the metadata fields. The interface will be part of the public API, and is returned by the newTaskMetadata.Id()API. The oldTaskMetadata.taskId()method that returns a String is also deprecated in this PRThe KIP is currently under voting so this PR can't be merged yet, but it is ready to be reviewed: KIP-740