KAFKA-12779: KIP-740, Clean up public API in TaskId and fix TaskMetadata#taskId()#10735
Merged
ableegoldman merged 3 commits intoapache:trunkfrom May 20, 2021
Conversation
ableegoldman
force-pushed
the
12779-clean-up-TaskId-and-return-on-TaskMetadata
branch
2 times, most recently
from
d63067f to
271ae62
Compare
ableegoldman
force-pushed
the
12779-clean-up-TaskId-and-return-on-TaskMetadata
branch
from
271ae62 to
cd58405
Compare
ableegoldman
requested review from
cadonna,
guozhangwang,
mjsax and
vvcephei
and removed request for
cadonna
Member
Author
|
@cadonna @guozhangwang @vvcephei This PR is now ready to review -- I know the KIP is not yet accepted but you can still give this a pass to see what the proposal looks like, and start the review so I can get this merged soon after the KIP is voted on |
guozhangwang
approved these changes
May 20, 2021
Contributor
guozhangwang
left a comment
guozhangwang
left a comment
There was a problem hiding this comment.
Made a pass on it, LGTM.
Member
Author
|
Just some unrelated failures in |
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
May 26, 2021
…e-allocations-lz4 * apache-github/trunk: (43 commits) KAFKA-12800: Configure generator to fail on trailing JSON tokens (apache#10717) MINOR: clarify message ordering with max in-flight requests and idempotent producer (apache#10690) MINOR: Add log identifier/prefix printing in Log layer static functions (apache#10742) MINOR: update java doc for deprecated methods (apache#10722) MINOR: Fix deprecation warnings in SlidingWindowedCogroupedKStreamImplTest (apache#10703) KAFKA-12499: add transaction timeout verification (apache#10482) KAFKA-12620 Allocate producer ids on the controller (apache#10504) MINOR: Kafka Streams code samples formating unification (apache#10651) KAFKA-12808: Remove Deprecated Methods under StreamsMetrics (apache#10724) KAFKA-12522: Cast SMT should allow null value records to pass through (apache#10375) KAFKA-12820: Upgrade maven-artifact dependency to resolve CVE-2021-26291 HOTFIX: fix checkstyle issue in KAFKA-12697 KAFKA-12697: Add OfflinePartitionCount and PreferredReplicaImbalanceCount metrics to Quorum Controller (apache#10572) KAFKA-12342: Remove MetaLogShim and use RaftClient directly (apache#10705) KAFKA-12779: KIP-740, Clean up public API in TaskId and fix TaskMetadata#taskId() (apache#10735) KAFKA-12814: Remove Deprecated Method StreamsConfig getConsumerConfigs (apache#10737) MINOR: Eliminate redundant functions in LogTest suite (apache#10732) MINOR: Remove unused maxProducerIdExpirationMs parameter in Log constructor (apache#10723) MINOR: Updating files with release 2.7.1 (apache#10660) KAFKA-12809: Remove deprecated methods of Stores factory (apache#10729) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in KIP-740, we clean up the public TaskId class and introduce new APIs to return it from TaskMetadata
The KIP is currently under voting so this PR can't be merged yet, but it is ready to be reviewed