KAFKA-5876: Add streamsState() method to StateStoreProvider#10825
KAFKA-5876: Add streamsState() method to StateStoreProvider#10825vitojeng wants to merge 1 commit intoapache:trunkfrom
streamsState() method to StateStoreProvider#10825Conversation
|
@ableegoldman Please take a look :) |
|
Hey @ableegoldman, just a remind. Please take a look, when you have time. :) |
ableegoldman
left a comment
There was a problem hiding this comment.
Just one high-level comment: if all we need this for is the state, then maybe we should just add a method for that instead of exposing the KafkaStreams object directly. Not that it really matters that much, but it's the "safe" thing to do to limit the access to only what's necessary.
Thoughts?
Agree, thanks for the suggestion. |
8cb5dee to
e2f6721
Compare
|
update PR & rebase trunk. Add |
streams() method to StateStoreProviderstreamsState() method to StateStoreProvider
|
This PR is being marked as stale since it has not had any activity in 90 days. If you If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact). If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed. |
|
This PR has been closed since it has not had any activity in 120 days. If you feel like this |
follow-up #8200
KAFKA-5876's PR break into multiple parts, this PR is part 5.
In KIP-216, the following exceptions is currently not completed: StreamsRebalancingException, StreamsRebalancingException, StateStoreNotAvailableException. In the CompositeReadOnlyXXXXStore class, we need using streams state to decide which exception should be thrown.
This PR add a new method
streams()to StateStoreProvider interface. In the next PR, we can get streams state in the CompositeReadOnlyXXXXStore class to determine which exception should be thrown.Committer Checklist (excluded from commit message)