Skip to content

KAFKA-5876: Add streamsState() method to StateStoreProvider#10825

Closed
vitojeng wants to merge 1 commit intoapache:trunkfrom
vitojeng:kafka-5876-part-5
Closed

KAFKA-5876: Add streamsState() method to StateStoreProvider#10825
vitojeng wants to merge 1 commit intoapache:trunkfrom
vitojeng:kafka-5876-part-5

Conversation

@vitojeng
Copy link
Copy Markdown
Contributor

@vitojeng vitojeng commented Jun 5, 2021

follow-up #8200

KAFKA-5876's PR break into multiple parts, this PR is part 5.

In KIP-216, the following exceptions is currently not completed: StreamsRebalancingException, StreamsRebalancingException, StateStoreNotAvailableException. In the CompositeReadOnlyXXXXStore class, we need using streams state to decide which exception should be thrown.

This PR add a new method streams() to StateStoreProvider interface. In the next PR, we can get streams state in the CompositeReadOnlyXXXXStore class to determine which exception should be thrown.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@vitojeng
Copy link
Copy Markdown
Contributor Author

vitojeng commented Jun 5, 2021

@ableegoldman Please take a look :)

@vitojeng
Copy link
Copy Markdown
Contributor Author

Hey @ableegoldman, just a remind. Please take a look, when you have time. :)

Copy link
Copy Markdown
Member

@ableegoldman ableegoldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one high-level comment: if all we need this for is the state, then maybe we should just add a method for that instead of exposing the KafkaStreams object directly. Not that it really matters that much, but it's the "safe" thing to do to limit the access to only what's necessary.

Thoughts?

@vitojeng
Copy link
Copy Markdown
Contributor Author

Just one high-level comment: if all we need this for is the state, then maybe we should just add a method for that instead of exposing the KafkaStreams object directly. Not that it really matters that much, but it's the "safe" thing to do to limit the access to only what's necessary.

Thoughts?

Agree, thanks for the suggestion.
Will update the PR.

@vitojeng vitojeng force-pushed the kafka-5876-part-5 branch from 8cb5dee to e2f6721 Compare June 23, 2021 12:25
@vitojeng
Copy link
Copy Markdown
Contributor Author

vitojeng commented Jun 23, 2021

update PR & rebase trunk.
Remove:

KafkaStreams streams();

Add

KafkaStreams.State streamsState();

@vitojeng vitojeng changed the title KAFKA-5876: Add streams() method to StateStoreProvider KAFKA-5876: Add streamsState() method to StateStoreProvider Jun 23, 2021
@mjsax mjsax added the streams label Dec 28, 2022
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 1, 2024

This PR is being marked as stale since it has not had any activity in 90 days. If you
would like to keep this PR alive, please leave a comment asking for a review. If the PR has
merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

@github-actions github-actions Bot added the stale Stale PRs label Dec 1, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 2, 2025

This PR has been closed since it has not had any activity in 120 days. If you feel like this
was a mistake, or you would like to continue working on it, please feel free to re-open the
PR and ask for a review.

@github-actions github-actions Bot added the closed-stale PRs that were closed due to inactivity label Jan 2, 2025
@github-actions github-actions Bot closed this Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

closed-stale PRs that were closed due to inactivity stale Stale PRs streams

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants