KAFKA-5876: IQ should throw different exceptions for different errors(part 1) by vitojeng · Pull Request #8200 · apache/kafka

vitojeng · 2020-03-02T13:59:10Z

KIP-216: IQ should throw different exceptions for different errors

KAFKA-5876's PR break into multiple parts. This PR is part 1: the new exceptions introduced in KIP-216

Committer Checklist (excluded from commit message)

Verify design and implementation
Verify test coverage and CI build status
Verify documentation (including upgrade notes)

vvcephei · 2020-03-02T15:34:37Z

test this please

mjsax · 2020-03-05T05:03:32Z

Thanks for the PR @vitojeng -- I put it into my review backlog :)

mjsax · 2020-03-07T18:33:10Z

@vitojeng This is a quite big PR -- would it make sense to break it into multiple? Maybe one that only add the new exception classed, and one each for using a new exception type?

vitojeng · 2020-03-07T23:34:27Z

@vitojeng This is a quite big PR -- would it make sense to break it into multiple? Maybe one that only add the new exception classed, and one each for using a new exception type?

@mjsax The same feeling. Break it into multiple part is a good way. I will force-push the new exceptions only in this PR first.

mjsax · 2020-05-29T00:59:29Z

Hey @vitojeng -- sorry for the long delay... We had a big KIP review back log... I would dedicate review time now to get KIP-216 merged. Are you still interested in pushing it over the finish line? If yes, I would start with this PR in the next days.

vitojeng · 2020-05-29T01:26:58Z

Hey @vitojeng -- sorry for the long delay... We had a big KIP review back log...

@mjsax Never mind, I understand. :)
I'll be rebase master again and update this PR ASAP.

vitojeng · 2020-05-29T02:23:02Z

@mjsax Just rebase & force-pushed.
You can start review when you available.

mjsax · 2020-05-29T18:48:40Z

Retest this please.

mjsax · 2020-05-29T18:48:51Z

Retest this please.

mjsax · 2020-05-29T18:49:04Z

Jenkins does not cooperator right now. Will try again later.

vitojeng · 2020-06-11T01:14:00Z

Address comments and rebase trunk.

vitojeng · 2020-06-11T01:15:08Z

Retest this please.

mjsax · 2020-06-11T03:03:19Z

@vitojeng -- Jenkins got locked down a couple of week ago. Only committer can trigger builds now.

vitojeng · 2020-06-11T03:42:53Z

Got it!

brary · 2020-06-11T04:12:18Z

LGTM!

mjsax

Sorry (again... :() for the delayed review. Couple of minor suggestions to improve the JavaDocs. The goal of the KIP was really to make it easier for users to reason about the type of error and thus we should be a little bit more elaborative.

…(part 1) Add new sub-classes of InvalidStateStoreException

vitojeng · 2020-07-18T15:37:48Z

@mjsax Thanks for the review. Already address your comment. :)

mjsax

Thanks for the update @vitojeng -- a few more nits. Overall LGTM. Will merge after addressed.

vitojeng · 2020-07-21T05:34:57Z

Thanks for the update @vitojeng -- a few more nits. Overall LGTM. Will merge after addressed.

Thanks @mjsax for the reviewing, just updated.

mjsax · 2020-07-22T22:40:02Z

Retest this please.

mjsax

LGTM.

Will merge after Jenkins passed.

mjsax · 2020-07-23T02:55:49Z

Merged to trunk. Thanks for the PR and patience @vitojeng!

Looking forward to the next PR(s) -- it's best to continue doing multiple smaller PRs (I leave it up to your judgment what the best way is to split the work in chunks.)

vitojeng · 2020-07-23T03:03:39Z

Looking forward to the next PR(s) -- it's best to continue doing multiple smaller PRs (I leave it up to your judgment what the best way is to split the work in chunks.)

Thanks @mjsax !
I would separate each new exception into different PRs. I guess this should be a better way for reviewing. Also thanks @brary for the reviewing.

…t-for-generated-requests * apache-github/trunk: (148 commits) MINOR: remove NewTopic#NO_PARTITIONS and NewTopic#NO_REPLICATION_FACTOR as they are duplicate to CreateTopicsRequest#NO_NUM_PARTITIONS and CreateTopicsRequest#NO_REPLICATION_FACTOR (apache#9077) MINOR: Remove staticmethod tag to be able to use logger of instance (apache#9086) MINOR: Adjust 'release.py' script to use shell when using gradlewAll and PGP signing, which were required to build the 2.6.0 RCs (apache#9045) MINOR: Update dependencies for Kafka 2.7 (part 1) (apache#9082) MINOR: INFO log4j when request re-join (apache#9068) MINOR: Recommend Java 11 (apache#9080) KAFKA-10306: GlobalThread should fail on InvalidOffsetException (apache#9075) KAFKA-10158: Fix flaky testDescribeUnderReplicatedPartitionsWhenReassignmentIsInProgress (apache#9022) MINOR: code cleanup for `VOut` inconsistent naming (apache#8907) KAFKA-10246 : AbstractProcessorContext topic() throws NPE (apache#9034) KAFKA-10305: Print usage when parsing fails for ConsumerPerformance (apache#9071) MINOR: removed incorrect deprecation annotations (apache#9061) MINOR: speed up release script (apache#9070) MINOR: add task ':streams:testAll' (apache#9073) KAFKA-10301: Do not clear Partition#remoteReplicasMap during partition assignment updates (apache#9065) KAFKA-10268: dynamic config like "--delete-config log.retention.ms" doesn't work (apache#9051) KAFKA-10300 fix flaky core/group_mode_transactions_test.py (apache#9059) MINOR: Publish metrics package in the javadoc (apache#9036) KAFKA-8264: decrease the record size for flaky test KAFKA-5876: Add new exception types for Interactive Queries (apache#8200) ...

vvcephei added the streams label Mar 2, 2020

vitojeng commented Mar 3, 2020

View reviewed changes

Comment thread ...s/src/main/java/org/apache/kafka/streams/state/internals/StreamThreadStateStoreProvider.java Outdated

vitojeng force-pushed the kip-216 branch from 4b25c79 to 57bf544 Compare March 7, 2020 23:59

vitojeng changed the title ~~KAFKA-5876: IQ should throw different exceptions for different errors~~ KAFKA-5876: IQ should throw different exceptions for different errors(part 1) Mar 8, 2020

vitojeng force-pushed the kip-216 branch from 57bf544 to f55b1ef Compare May 29, 2020 02:18

brary reviewed Jun 10, 2020

View reviewed changes

vitojeng force-pushed the kip-216 branch from f55b1ef to fc8954f Compare June 11, 2020 01:12

mjsax added the kip Requires or implements a KIP label Jun 12, 2020

mjsax reviewed Jul 17, 2020

View reviewed changes

vitojeng added 2 commits July 18, 2020 23:17

KAFKA-5876: IQ should throw different exceptions for different errors…

12ae090

…(part 1) Add new sub-classes of InvalidStateStoreException

address comments

f3136d4

vitojeng force-pushed the kip-216 branch from b6c023f to f3136d4 Compare July 18, 2020 15:25

mjsax reviewed Jul 20, 2020

View reviewed changes

address comments

6cf8ee4

mjsax approved these changes Jul 22, 2020

View reviewed changes

mjsax merged commit 2d79171 into apache:trunk Jul 23, 2020

vitojeng deleted the kip-216 branch July 23, 2020 02:55

vitojeng mentioned this pull request Jul 24, 2020

KAFKA-5876: Apply UnknownStateStoreException for Interactive Queries #9069

Closed

3 tasks

vitojeng mentioned this pull request Jan 4, 2021

KAFKA-5876: Apply UnknownStateStoreException for Interactive Queries #9821

Merged

3 tasks

vitojeng mentioned this pull request Apr 26, 2021

KAFKA-5876: Apply StreamsNotStartedException for Interactive Queries #10597

Merged

3 tasks

vitojeng mentioned this pull request May 9, 2021

KAFKA-5876: Apply InvalidStateStorePartitionException for Interactive Queries #10657

Merged

3 tasks

vitojeng mentioned this pull request Jun 5, 2021

KAFKA-5876: Add streamsState() method to StateStoreProvider #10825

Closed

3 tasks

Conversation

vitojeng commented Mar 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Committer Checklist (excluded from commit message)

Uh oh!

vvcephei commented Mar 2, 2020

Uh oh!

Uh oh!

mjsax commented Mar 5, 2020

Uh oh!

mjsax commented Mar 7, 2020

Uh oh!

vitojeng commented Mar 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mjsax commented May 29, 2020

Uh oh!

vitojeng commented May 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vitojeng commented May 29, 2020

Uh oh!

mjsax commented May 29, 2020

Uh oh!

mjsax commented May 29, 2020

Uh oh!

mjsax commented May 29, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vitojeng commented Jun 11, 2020

Uh oh!

vitojeng commented Jun 11, 2020

Uh oh!

mjsax commented Jun 11, 2020

Uh oh!

vitojeng commented Jun 11, 2020

Uh oh!

brary commented Jun 11, 2020

Uh oh!

mjsax left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vitojeng commented Jul 18, 2020

Uh oh!

mjsax left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vitojeng commented Jul 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mjsax commented Jul 22, 2020

Uh oh!

mjsax left a comment

Choose a reason for hiding this comment

Uh oh!

mjsax commented Jul 23, 2020

Uh oh!

vitojeng commented Jul 23, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

vitojeng commented Mar 2, 2020 •

edited

Loading

vitojeng commented Mar 7, 2020 •

edited

Loading

vitojeng commented May 29, 2020 •

edited

Loading

vitojeng commented Jul 21, 2020 •

edited

Loading