FIX: Remove staticmethod tag to be able to use logger of instance#9086
Merged
mjsax merged 1 commit intoapache:trunkfrom Jul 27, 2020
Merged
FIX: Remove staticmethod tag to be able to use logger of instance#9086mjsax merged 1 commit intoapache:trunkfrom
mjsax merged 1 commit intoapache:trunkfrom
Conversation
A system test failed with the following error global name 'self' is not defined The reason was that self was accessed to log a message in a static method. This commit makes the method an instance method.
Member
Author
|
Call for review: @ableegoldman @mjsax |
Member
Author
|
Run of system tests that use the modified method: |
mjsax
pushed a commit
that referenced
this pull request
Jul 27, 2020
…9086) A system test failed with the following error: global name 'self' is not defined The reason was that `self` was accessed to log a message in a static method. This commit makes the method an instance method. Reviewer: Matthias J. Sax <matthias@confluent.io>
mjsax
pushed a commit
that referenced
this pull request
Jul 27, 2020
…9086) A system test failed with the following error: global name 'self' is not defined The reason was that `self` was accessed to log a message in a static method. This commit makes the method an instance method. Reviewer: Matthias J. Sax <matthias@confluent.io>
mjsax
pushed a commit
that referenced
this pull request
Jul 27, 2020
…9086) A system test failed with the following error: global name 'self' is not defined The reason was that `self` was accessed to log a message in a static method. This commit makes the method an instance method. Reviewer: Matthias J. Sax <matthias@confluent.io>
mjsax
pushed a commit
that referenced
this pull request
Jul 27, 2020
…9086) A system test failed with the following error: global name 'self' is not defined The reason was that `self` was accessed to log a message in a static method. This commit makes the method an instance method. Reviewer: Matthias J. Sax <matthias@confluent.io>
Member
|
Merged to |
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
Nov 17, 2020
…t-for-generated-requests * apache-github/trunk: (148 commits) MINOR: remove NewTopic#NO_PARTITIONS and NewTopic#NO_REPLICATION_FACTOR as they are duplicate to CreateTopicsRequest#NO_NUM_PARTITIONS and CreateTopicsRequest#NO_REPLICATION_FACTOR (apache#9077) MINOR: Remove staticmethod tag to be able to use logger of instance (apache#9086) MINOR: Adjust 'release.py' script to use shell when using gradlewAll and PGP signing, which were required to build the 2.6.0 RCs (apache#9045) MINOR: Update dependencies for Kafka 2.7 (part 1) (apache#9082) MINOR: INFO log4j when request re-join (apache#9068) MINOR: Recommend Java 11 (apache#9080) KAFKA-10306: GlobalThread should fail on InvalidOffsetException (apache#9075) KAFKA-10158: Fix flaky testDescribeUnderReplicatedPartitionsWhenReassignmentIsInProgress (apache#9022) MINOR: code cleanup for `VOut` inconsistent naming (apache#8907) KAFKA-10246 : AbstractProcessorContext topic() throws NPE (apache#9034) KAFKA-10305: Print usage when parsing fails for ConsumerPerformance (apache#9071) MINOR: removed incorrect deprecation annotations (apache#9061) MINOR: speed up release script (apache#9070) MINOR: add task ':streams:testAll' (apache#9073) KAFKA-10301: Do not clear Partition#remoteReplicasMap during partition assignment updates (apache#9065) KAFKA-10268: dynamic config like "--delete-config log.retention.ms" doesn't work (apache#9051) KAFKA-10300 fix flaky core/group_mode_transactions_test.py (apache#9059) MINOR: Publish metrics package in the javadoc (apache#9036) KAFKA-8264: decrease the record size for flaky test KAFKA-5876: Add new exception types for Interactive Queries (apache#8200) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A system test failed with the following error
global name 'self' is not defined
The reason was that self was accessed in a static
method to log a message.
This commit makes the method an instance method.
Committer Checklist (excluded from commit message)