Skip to content

MINOR: add task ':streams:testAll'#9073

Merged
vvcephei merged 2 commits intoapache:trunkfrom
vvcephei:minor-streams-testAll
Jul 24, 2020
Merged

MINOR: add task ':streams:testAll'#9073
vvcephei merged 2 commits intoapache:trunkfrom
vvcephei:minor-streams-testAll

Conversation

@vvcephei
Copy link
Copy Markdown
Contributor

Adds a new task to Streams to run all the tests for all sub-projects.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

Copy link
Copy Markdown

@abbccdda abbccdda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran on local to verify it works.

@abbccdda
Copy link
Copy Markdown

One more thought, it might be useful to add this to the repo README if a user is only doing stream side changes and want to test it out on local @vvcephei.

@vvcephei
Copy link
Copy Markdown
Contributor Author

Thanks @abbccdda ! There was only one flaky test, and the last change was only to the README, so I'll merge now.

@vvcephei vvcephei merged commit a44ac3b into apache:trunk Jul 24, 2020
@vvcephei vvcephei deleted the minor-streams-testAll branch July 24, 2020 20:30
Comment thread build.gradle
':streams:upgrade-system-tests-22:test',
':streams:upgrade-system-tests-23:test',
':streams:upgrade-system-tests-24:test',
':streams:upgrade-system-tests-25:test',
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we have actual unit/integration tests in those packages? Also seems a pain to keep it updates (and I am sure we will forget to update it). Should we just skip those?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. Already merged. Never mind.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comment anyway.

I was on the fence about it, but I went with including these projects just to be sure that testAll really tests all of the components of :streams. Even though they don't have tests, the :test target is convenient because it runs all of the compilation targets, as well as spotbugs and checkstyle. The idea is just to flush out any/all possible sources of failure so that we can be pretty sure that if :streams:testAll passes, then so will Jenkins.

I agree it's a pain. Maybe we can consider either contributing a script to keep this stuff updated or writing some gradle code to build the list automatically.

vvcephei added a commit that referenced this pull request Sep 28, 2020
Adds a new task (`:streams:testAll`) to gradle to run all the tests for all Streams sub-projects.

Reviewers: Boyang Chen <boyang@confluent.io>
vvcephei added a commit that referenced this pull request Sep 28, 2020
Adds a new task (`:streams:testAll`) to gradle to run all the tests for all Streams sub-projects.

Reviewers: Boyang Chen <boyang@confluent.io>
vvcephei added a commit that referenced this pull request Sep 28, 2020
Adds a new task (`:streams:testAll`) to gradle to run all the tests for all Streams sub-projects.

Reviewers: Boyang Chen <boyang@confluent.io>
ijuma added a commit to ijuma/kafka that referenced this pull request Nov 17, 2020
…t-for-generated-requests

* apache-github/trunk: (148 commits)
  MINOR: remove NewTopic#NO_PARTITIONS and NewTopic#NO_REPLICATION_FACTOR as they are duplicate to CreateTopicsRequest#NO_NUM_PARTITIONS and CreateTopicsRequest#NO_REPLICATION_FACTOR (apache#9077)
  MINOR: Remove staticmethod tag to be able to use logger of instance (apache#9086)
  MINOR: Adjust 'release.py' script to use shell when using gradlewAll and PGP signing, which were required to build the 2.6.0 RCs (apache#9045)
  MINOR: Update dependencies for Kafka 2.7 (part 1) (apache#9082)
  MINOR: INFO log4j when request re-join (apache#9068)
  MINOR: Recommend Java 11 (apache#9080)
  KAFKA-10306: GlobalThread should fail on InvalidOffsetException (apache#9075)
  KAFKA-10158: Fix flaky testDescribeUnderReplicatedPartitionsWhenReassignmentIsInProgress (apache#9022)
  MINOR: code cleanup for `VOut` inconsistent naming (apache#8907)
  KAFKA-10246 : AbstractProcessorContext topic() throws NPE (apache#9034)
  KAFKA-10305: Print usage when parsing fails for ConsumerPerformance (apache#9071)
  MINOR: removed incorrect deprecation annotations (apache#9061)
  MINOR: speed up release script (apache#9070)
  MINOR: add task ':streams:testAll' (apache#9073)
  KAFKA-10301: Do not clear Partition#remoteReplicasMap during partition assignment updates (apache#9065)
  KAFKA-10268: dynamic config like "--delete-config log.retention.ms" doesn't work (apache#9051)
  KAFKA-10300 fix flaky core/group_mode_transactions_test.py (apache#9059)
  MINOR: Publish metrics package in the javadoc (apache#9036)
  KAFKA-8264: decrease the record size for flaky test
  KAFKA-5876: Add new exception types for Interactive Queries (apache#8200)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants