KAFKA-13228: ApiVersionRequest is not properly handled in KRaft co-resident mode

[dengziming]

More detailed description of your change

When I described quorum in Kraft mode I got org.apache.kafka.common.errors.UnsupportedVersionException: The broker does not support DESCRIBE_QUORUM.
This happens because we only concerns ApiKeys.zkBrokerApis() when we call NodeApiVersions.create(), we should use ApiKeys.controllerApiVersions when in Kraft mode.

Summary of testing strategy (including rationale)

After this change, the DESCRIBE_QUORUM request was property handled and got a correct response:

TopicData(topicName='__cluster_metadata', partitions=[PartitionData(partitionIndex=0, errorCode=0, leaderId=1, leaderEpoch=30, highWatermark=141, currentVoters=[ReplicaState(replicaId=1, logEndOffset=141)], observers=[])])

[dengziming]

Hello @hachikuji , you changed NodeApiVersions.create() to account for ApiKeys.zkBrokerApis() in #10066 , but this is not right if the controller is KRaft mode, I added a controllerBrokerType in BrokerToControllerChannelManagerImpl to solve this problem. Also cc @abbccdda

[dengziming]

This will be solved in #11274

[dengziming]

These overrides are unnecessary if we use ClusterTestExtensions

[dengziming]

This will result in NPE

[dengziming]

I also found that we do not support UpdateFeaturesRequest in KRaft mode, so I also removed related tests. ping @hachikuji to have a look, thank you 🤝

[dengziming]

Hello @mumrah , are you interested in reviewing this, currently, APiVersionRequest is not properly handled in KRaft server and will have a bad effect on KIP-778.

[dengziming]

Hello @mumrah , are you interested in reviewing this? currently, APiVersionRequest is not properly handled in KRaft server and will have a bad effect on KIP-778.

[ijuma]

Was this fixed some other way?

[dengziming]

Was this fixed some other way?

No, there are too many conflicts, I split this PR into 2 PRs, #12157 and #11784.

[ijuma]

Thanks!