MINOR: Support co-resident mode in KRaft TestKit#12157
Closed
dengziming wants to merge 1 commit intoapache:trunkfrom
Closed
MINOR: Support co-resident mode in KRaft TestKit#12157dengziming wants to merge 1 commit intoapache:trunkfrom
dengziming wants to merge 1 commit intoapache:trunkfrom
Conversation
3 tasks
hachikuji
reviewed
May 25, 2022
| for (ControllerNode node : nodes.controllerNodes().values()) { | ||
| Map<String, String> props = new HashMap<>(configProps); | ||
| props.put(KafkaConfig$.MODULE$.ProcessRolesProp(), "controller"); | ||
| props.put(KafkaConfig$.MODULE$.ProcessRolesProp(), roles(node.id())); |
Contributor
There was a problem hiding this comment.
Something that was never quite clear to me is why we bother working with the lower-level ControllerServer and BrokerServer instances in this class. It seems like it would be simpler to use KafkaRaftServer which is already doing the dirty work of building KafkaRaftManager and the server objects. Not saying you have to do that here, but it would be useful to know if there is an actual benefit.
Member
Author
There was a problem hiding this comment.
Yeah, I think that's a good point. I will try to improve this.
Member
Author
|
Close this currently since it has been done in another PR, and I created KAFKA-14047 for the discussion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More detailed description of your change
The behavior between co-resident mode and discrete mode is different, so we should support co-resident mode too. I also find a bug in co-resident, see KAFKA-13228.
Summary of testing strategy (including rationale)
Changed existing clusterTest to support co-resident mode except for ApiVersionsRequestTest, which is related to a bug.
Committer Checklist (excluded from commit message)