KAFKA-10712; Update release scripts to Python3#11538
Merged
dajac merged 1 commit intoapache:trunkfrom Nov 29, 2021
Merged
Conversation
dajac
commented
Nov 25, 2021
| if version == 8: | ||
| if "1.8.0" not in java_version: | ||
| fail("JDK 8 is required") | ||
| elif "%d.0" % version not in java_version and '"%d"' % version not in java_version: |
Member
Author
There was a problem hiding this comment.
We had a bug here. The script should fail if both conditions are not met.
Member
Author
|
I've ran the script and everything seems to work correctly. |
mimaison
approved these changes
Nov 26, 2021
Member
mimaison
left a comment
mimaison
left a comment
There was a problem hiding this comment.
Thanks for picking this up. LGTM
dajac
added a commit
that referenced
this pull request
Nov 29, 2021
Reviewers: Mickael Maison <mickael.maison@gmail.com>
hgeraldino
pushed a commit
to hgeraldino/kafka
that referenced
this pull request
Nov 29, 2021
Reviewers: Mickael Maison <mickael.maison@gmail.com>
xdgrulez
pushed a commit
to xdgrulez/kafka
that referenced
this pull request
Dec 22, 2021
Reviewers: Mickael Maison <mickael.maison@gmail.com>
tombentley
pushed a commit
that referenced
this pull request
Sep 2, 2022
Reviewers: Mickael Maison <mickael.maison@gmail.com>
fmin
added a commit
to confluentinc/kafka
that referenced
this pull request
Sep 14, 2022
…2022 * apache-kafka/3.0: (15 commits) MINOR: Update 3.0 branch version to 3.0.3-SNAPSHOT Upgrade Netty and Jackson versions for CVE fixes [KAFKA-14044] (apache#12376) Bump version to 3.0.2 KAFKA-10712; Update release scripts to Python3 (apache#11538) MINOR: Update LICENSE-binary MINOR: Update docs/upgrade.html MINOR: Update version to 3.0.2 MINOR: Add configurable max receive size for SASL authentication requests MINOR: Add more validation during KRPC deserialization MINOR: Add note on IDEMPOTENT_WRITE ACL to notable changes (apache#12260) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made the following changes so that it works in Python3:
basestringbystrCommitter Checklist (excluded from commit message)