Skip to content

MINOR: add note on IDEMPOTENT_WRITE ACL to 3.2.0 notable changes#12260

Merged
ijuma merged 10 commits intoapache:trunkfrom
d-t-w:add-idempotence-acl-notable-changes
Aug 13, 2022
Merged

MINOR: add note on IDEMPOTENT_WRITE ACL to 3.2.0 notable changes#12260
ijuma merged 10 commits intoapache:trunkfrom
d-t-w:add-idempotence-acl-notable-changes

Conversation

@d-t-w
Copy link
Copy Markdown
Contributor

@d-t-w d-t-w commented Jun 7, 2022

Update 3.2.0 notable changes documentation to include a subsection on requiring IDEMPOTENT_WRITE permission when producing messages with default/idempotent configuration and broker version lower than 2.8.0.

showuon
showuon reviewed Jun 7, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@showuon showuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d-t-w , thanks for the PR. I think we should also put the same message to Notable changes in 3.0.1 (L215) and 3.1.1 (L138). Thanks.

@d-t-w
Copy link
Copy Markdown
Contributor Author

d-t-w commented Jun 7, 2022

Thanks @showuon I have updated per your comment

ijuma
ijuma reviewed Jun 7, 2022
View reviewed changes
Comment thread docs/upgrade.html Outdated
(See <a href="https://issues.apache.org/jira/browse/KAFKA-13598">KAFKA-13598</a>for more details).
This issue was fixed and the default is properly applied in 3.0.1, 3.1.1, and 3.2.0.</li>
<ul>
<li>When the broker version is lower than 2.8.0, and the client version is 3.0.1, 3.1.1, and later, the IDEMPOTENT_WRITE permission is required to produce data</li>
Copy link
Copy Markdown
Member

@ijuma ijuma Jun 7, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say something like: Please read the relevant KIP section for the compatibility implications - a noteworthy item worth highlighting is...

Also, we should use the same approach for this and other lines. It's unclear to me why we added a ul here, but not in the other case. I'd probably include this paragraph in the previous li

Copy link
Copy Markdown
Member

@ijuma ijuma Aug 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I was unclear here. I clarified in #12260 (comment)

@d-t-w
Copy link
Copy Markdown
Contributor Author

d-t-w commented Jun 8, 2022

Hi @ijuma I rm'd the ul tag.

That format was originally requested in the comments here: https://issues.apache.org/jira/browse/KAFKA-13598

More info here: https://kpow.io/articles/kafka-producer-breaking-change/

I'm not sure including this line in the previous li is a good idea that mixes this note into the context of a statement about Connect, this breaking change impacts any user of Kafka where:

  1. The Kafka Cluster has brokers running version < 2.8.0, and
  2. The Kafka Cluster has ACLs configured, but not IDEMPOTENT_WRITE, and
  3. Producer configuration is default, or capable of being defaulted to idempotent
  4. The producing application is using Kafka-Clients version > 3.2.0

@ijuma
Copy link
Copy Markdown
Member

ijuma commented Aug 12, 2022

@d-t-w I tweaked it a bit. Does this look OK to you? Basically, I wanted to include this note in the main bullet point regarding the change.

@d-t-w
Copy link
Copy Markdown
Contributor Author

d-t-w commented Aug 12, 2022

Hi @ijuma yes it looks good to me.

@ijuma ijuma merged commit 2539be9 into apache:trunk Aug 13, 2022
ijuma pushed a commit that referenced this pull request Aug 13, 2022
@d-t-w @ijuma
MINOR: Add note on IDEMPOTENT_WRITE ACL to notable changes (#12260)
a2110e6 
Update notable changes documentation to mention requiring IDEMPOTENT_WRITE permission
when producing messages with default/idempotent configuration and broker version lower than
2.8.0.

Reviewers: Ismael Juma <ismael@juma.me.uk>, Luke Chen <showuon@gmail.com>
ijuma pushed a commit that referenced this pull request Aug 13, 2022
@d-t-w @ijuma
MINOR: Add note on IDEMPOTENT_WRITE ACL to notable changes (#12260)
f60ddc9 
Update notable changes documentation to mention requiring IDEMPOTENT_WRITE permission
when producing messages with default/idempotent configuration and broker version lower than
2.8.0.

Reviewers: Ismael Juma <ismael@juma.me.uk>, Luke Chen <showuon@gmail.com>
ijuma pushed a commit that referenced this pull request Aug 13, 2022
@d-t-w @ijuma
MINOR: Add note on IDEMPOTENT_WRITE ACL to notable changes (#12260)
0717f5b 
Update notable changes documentation to mention requiring IDEMPOTENT_WRITE permission
when producing messages with default/idempotent configuration and broker version lower than
2.8.0.

Reviewers: Ismael Juma <ismael@juma.me.uk>, Luke Chen <showuon@gmail.com>
ijuma pushed a commit that referenced this pull request Aug 13, 2022
@d-t-w @ijuma
MINOR: Add note on IDEMPOTENT_WRITE ACL to notable changes (#12260)
967b89f 
Update notable changes documentation to mention requiring IDEMPOTENT_WRITE permission
when producing messages with default/idempotent configuration and broker version lower than
2.8.0.

Reviewers: Ismael Juma <ismael@juma.me.uk>, Luke Chen <showuon@gmail.com>
@ijuma
Copy link
Copy Markdown
Member

ijuma commented Aug 13, 2022

Merged to trunk, 3.3, 3.2, 3.1 and 3.0.

fmin added a commit to confluentinc/kafka that referenced this pull request Sep 14, 2022
@fmin
Merge remote-tracking branch 'apache-kafka/3.0' into sync-3.0-14-SEP-…
e85a8e0 
…2022

* apache-kafka/3.0: (15 commits)
  MINOR: Update 3.0 branch version to 3.0.3-SNAPSHOT
  Upgrade Netty and Jackson versions for CVE fixes [KAFKA-14044] (apache#12376)
  Bump version to 3.0.2
  KAFKA-10712; Update release scripts to Python3 (apache#11538)
  MINOR: Update LICENSE-binary
  MINOR: Update docs/upgrade.html
  MINOR: Update version to 3.0.2
  MINOR: Add configurable max receive size for SASL authentication requests
  MINOR: Add more validation during KRPC deserialization
  MINOR: Add note on IDEMPOTENT_WRITE ACL to notable changes (apache#12260)
  ...
@fmin fmin mentioned this pull request Sep 14, 2022
Merged
fmin added a commit to confluentinc/kafka that referenced this pull request Sep 14, 2022
@fmin
Merge remote-tracking branch 'apache-kafka/3.1' into sync-upstream-3.…
44e83d1 
…1-14-SEP-2022

* apache-kafka/3.1: (17 commits)
  MINOR: Update 3.1 branch version to 3.1.3-SNAPSHOT
  Upgrade Netty and Jackson versions for CVE fixes [KAFKA-14044] (apache#12376)
  Bump version to 3.1.2
  MINOR: Update LICENSE-binary
  MINOR: Bump version in upgrade guide to 3.1.2
  MINOR: Add configurable max receive size for SASL authentication requests
  MINOR: Add more validation during KRPC deserialization
  MINOR: Add note on IDEMPOTENT_WRITE ACL to notable changes (apache#12260)
  KAFKA-14107: Upgrade Jetty version for CVE fixes (apache#12440)
  KAFKA-14062: OAuth client token refresh fails with SASL extensions (apache#12398)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ijuma ijuma ijuma left review comments

@showuon showuon showuon left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@d-t-w @ijuma @showuon