MINOR; Enable Kraft in ApiVersionTest#11667
Merged
hachikuji merged 8 commits intoapache:trunkfrom Feb 15, 2022
Merged
Conversation
hachikuji
reviewed
Feb 4, 2022
dengziming
force-pushed
the
remove-junit-testkip
branch
from
3c42333 to
2e2131c
Compare
hachikuji
reviewed
Feb 8, 2022
Contributor
hachikuji
left a comment
hachikuji
left a comment
There was a problem hiding this comment.
Thanks @dengziming . I left a few small comments.
hachikuji
reviewed
Feb 9, 2022
hachikuji
reviewed
Feb 11, 2022
Contributor
hachikuji
left a comment
hachikuji
left a comment
There was a problem hiding this comment.
Thanks @dengziming . Just one more comment.
hachikuji
reviewed
Feb 11, 2022
Contributor
hachikuji
left a comment
hachikuji
left a comment
There was a problem hiding this comment.
The updates look good. Note that CreateTopicsRequestWithForwardingTest is failing because of the change in ApiVersionManager. I think we can just remove the cases that expect forwarding on zk clusters for now.
dengziming
force-pushed
the
remove-junit-testkip
branch
from
3858f92 to
b927696
Compare
hachikuji
reviewed
Feb 12, 2022
hachikuji
approved these changes
Feb 15, 2022
Contributor
hachikuji
left a comment
hachikuji
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the patch!
dengziming
force-pushed
the
remove-junit-testkip
branch
from
1eab4ef to
9e33619
Compare
dengziming
force-pushed
the
remove-junit-testkip
branch
from
9e33619 to
f87f9e7
Compare
3 tasks
showuon
pushed a commit
that referenced
this pull request
Aug 31, 2022
cmccabe
pushed a commit
that referenced
this pull request
Aug 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More detailed description of your change
Summary of testing strategy (including rationale)
QA
Committer Checklist (excluded from commit message)