Skip to content

MINOR: Enable testUpdateFeaturesWithForwarding#12059

Merged
showuon merged 1 commit intoapache:trunkfrom
dengziming:minor-update-feature-test
Aug 31, 2022
Merged

MINOR: Enable testUpdateFeaturesWithForwarding#12059
showuon merged 1 commit intoapache:trunkfrom
dengziming:minor-update-feature-test

Conversation

@dengziming
Copy link
Copy Markdown
Member

More detailed description of your change
This test was removed in #11667 since UpdateFeatures is not properly handled in KRaft mode, now we can bring it back since UpdateFeatures is properly handled after #12036.

Summary of testing strategy (including rationale)
No

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@dengziming
Copy link
Copy Markdown
Member Author

ping @mumrah

@divijvaidya
Copy link
Copy Markdown
Member

Looks good to me!

Copy link
Copy Markdown
Member

@showuon showuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@showuon
Copy link
Copy Markdown
Member

showuon commented Aug 30, 2022

@dengziming , could you rebase this branch to the latest trunk branch? I'd like to check the test result. Thanks.

@dengziming dengziming force-pushed the minor-update-feature-test branch from 5c2c555 to 165a063 Compare August 30, 2022 06:39
@dengziming
Copy link
Copy Markdown
Member Author

could you rebase this branch to the latest trunk branch? I'd like to check the test result. Thanks.

Thank you @showuon , I have rebased this PR onto trunk.

@showuon
Copy link
Copy Markdown
Member

showuon commented Aug 30, 2022

Let's wait for the test results :)

@dengziming dengziming force-pushed the minor-update-feature-test branch from 165a063 to c503459 Compare August 30, 2022 11:00
@showuon
Copy link
Copy Markdown
Member

showuon commented Aug 31, 2022

Failed test is unrelated.

Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.integration.ExactlyOnceSourceIntegrationTest.testConnectorBoundary

@showuon showuon merged commit 6f47783 into apache:trunk Aug 31, 2022
cmccabe pushed a commit that referenced this pull request Aug 31, 2022
This test was removed in #11667 since UpdateFeatures is not properly handled in KRaft mode, now we can bring it back since UpdateFeatures is properly handled after #12036.

Reviewers: Luke Chen <showuon@gmail.com>
@dengziming dengziming deleted the minor-update-feature-test branch October 8, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants