KAFKA-13599: Upgrade RocksDB to 6.27.3#11690
Merged
cadonna merged 3 commits intoapache:trunkfrom Feb 2, 2022
Merged
Conversation
Member
|
@jonathan-albrecht-ibm Thank you for the PR! I will review it this or next week. |
Contributor
Author
|
Thanks @cadonna! |
Contributor
Author
|
Hi @cadonna, just wondering if you are still able to review this week or if it will be pushed out to next? Not trying to rush anything, I appreciate the time you can spend on it. |
Member
|
Sorry, I got sick and need to move the review to next week. |
Contributor
Author
|
Thanks @cadonna. Get well soon |
showuon
reviewed
Jan 30, 2022
Member
showuon
left a comment
showuon
left a comment
There was a problem hiding this comment.
@jonathan-albrecht-ibm , thanks for the PR. Overall lgtm. Just a minor comment left.
@cadonna , get well soon!
| } | ||
|
|
||
| @Override | ||
| public Options setEnableBlobFiles(final boolean enableBlobFiles) { |
Member
There was a problem hiding this comment.
Started here, they are options for blobsDB. In the upstream Options.java, there are comments at the beginning and the end of the options. Could we add something similar here?
//
// BEGIN options for blobs (integrated BlobDB)
// //
// END options for blobs (integrated BlobDB)
//Thanks.
Contributor
Author
There was a problem hiding this comment.
TFTR @showuon! I've added in the comments, let me know how it looks.
cadonna
approved these changes
Feb 1, 2022
Member
cadonna
left a comment
cadonna
left a comment
There was a problem hiding this comment.
@jonathan-albrecht-ibm Thanks for the PR!
LGTM!
Member
|
I re-triggered the builds. Once the builds are acceptable, I will merge. |
Member
|
Failing test are unrelated: |
Contributor
Author
|
Thanks @cadonna! |
Merged
8 tasks
cadonna
pushed a commit
that referenced
this pull request
Nov 16, 2022
RocksDB v6.27.3 has been released and it is the first release to support s390x. RocksDB is currently the only dependency in gradle/dependencies.gradle without s390x support. RocksDB v6.27.3 has added some new options that require an update to streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java but no other changes are needed to upgrade. I have run the unit/integration tests locally on s390x and also the :streams tests on x86_64 and they pass. Reviewers: Luke Chen <showuon@gmail.com>, Bruno Cadonna <cadonna@apache.org>
cadonna
pushed a commit
that referenced
this pull request
Nov 16, 2022
RocksDB v6.27.3 has been released and it is the first release to support s390x. RocksDB is currently the only dependency in gradle/dependencies.gradle without s390x support. RocksDB v6.27.3 has added some new options that require an update to streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java but no other changes are needed to upgrade. I have run the unit/integration tests locally on s390x and also the :streams tests on x86_64 and they pass. Reviewers: Luke Chen <showuon@gmail.com>, Bruno Cadonna <cadonna@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RocksDB v6.27.3 has been released and it is the first release to support s390x. RocksDB is currently the only dependency in gradle/dependencies.gradle without s390x support.
RocksDB v6.27.3 has added some new options that require an update to streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java but no other changes are needed to upgrade.
I have run the unit/integration tests locally on s390x and also the :streams tests on x86_64 and they pass.
Committer Checklist (excluded from commit message)