KAFKA-10000: Add new preflight connector config validation logic (KIP-618)#11776
Conversation
|
Converting to draft until upstream PRs are reviewed. |
c687a12 to
b4976e8
Compare
d5c0478 to
4752939
Compare
4752939 to
7c20275
Compare
|
Given that all merge conflicts have been resolved and #11775 has already been approved, marking this as ready for review. |
7c20275 to
923af52
Compare
|
@showuon the 3.3.0 feature freeze is a little over a month away and there are still seven open pull requests for this feature. Do you have time to take a look? |
|
@showuon If you do not have time to take a look, is there anyone you can recommend in your place? |
|
@showuon hello? Is anyone actually maintaining Kafka Connect anymore or should we all just stop contributing to it? |
There was a problem hiding this comment.
Is it safe to assume validatedName != null at this point?
There was a problem hiding this comment.
Yes; every framework-level connector property should have a ConfigValue entry in the map here.
There was a problem hiding this comment.
Factor out this else if/else logic into a method, since it's the same between the connectorUsesConsumer and connectorUsesAdmin methods?
There was a problem hiding this comment.
Could we assert on error message equality (or contains if there can be more than one)? As well was making the tests clearer it would make it clearer that we're actually hitting the expected validation condition.
923af52 to
6f420b1
Compare
|
Thanks Tom, addressed the nits. |
Implements the preflight validation logic described in KIP-618.
Relies on changes from: